Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932829AbeALCUg (ORCPT + 1 other); Thu, 11 Jan 2018 21:20:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:47714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932283AbeALCUf (ORCPT ); Thu, 11 Jan 2018 21:20:35 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE96A214C5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org X-Google-Smtp-Source: ACJfBouTDsUBaadL7zgwFItHP/uEG4SW2vTJ57VRv5v+qSC7BG9Eb9GuedA35FtsiR95aEO+tspU+uF5Qd2Mg9EZT+4= MIME-Version: 1.0 In-Reply-To: <20180112015231.GA44418@otc-nc-03> References: <1515720739-43819-1-git-send-email-ashok.raj@intel.com> <1515720739-43819-2-git-send-email-ashok.raj@intel.com> <20180112015231.GA44418@otc-nc-03> From: Andy Lutomirski Date: Thu, 11 Jan 2018 18:20:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl To: "Raj, Ashok" Cc: Andy Lutomirski , LKML , Thomas Gleixner , Tim Chen , Linus Torvalds , Greg KH , Dave Hansen , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , David Woodhouse , Peter Zijlstra , Dan Williams , Paolo Bonzini , Jun Nakajima , Asit Mallick Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: > On Thu, Jan 11, 2018 at 05:41:34PM -0800, Andy Lutomirski wrote: >> On Thu, Jan 11, 2018 at 5:32 PM, Ashok Raj wrote: >> > - Remove including microcode.h, and use native macros from asm/msr.h >> > - added license header for spec_ctrl.c >> > >> > Signed-off-by: Ashok Raj > > [snip] >> > +static inline u64 native_rdmsrl(unsigned int msr) >> > +{ >> > + u64 val; >> > + >> > + val = __rdmsr(msr); >> > + >> > + return val; >> > +} >> >> What's wrong with native_read_msr()? > > Yes, i think i should have added to msr.h. The names didn't read as a > pair, one was native_read_msr, wrmsrl could be taken over when paravirt is > defined? Why do you need to override paravirt?