Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbeALDBm (ORCPT + 1 other); Thu, 11 Jan 2018 22:01:42 -0500 Received: from mga09.intel.com ([134.134.136.24]:36281 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932538AbeALDBl (ORCPT ); Thu, 11 Jan 2018 22:01:41 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; d="scan'208";a="20971668" Date: Thu, 11 Jan 2018 19:01:40 -0800 From: "Raj, Ashok" To: Andy Lutomirski Cc: LKML , Thomas Gleixner , Tim Chen , Linus Torvalds , Greg KH , Dave Hansen , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , David Woodhouse , Peter Zijlstra , Dan Williams , Paolo Bonzini , Jun Nakajima , Asit Mallick , ashok.raj@intel.com Subject: Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl Message-ID: <20180112030139.GA46095@otc-nc-03> References: <1515720739-43819-1-git-send-email-ashok.raj@intel.com> <1515720739-43819-2-git-send-email-ashok.raj@intel.com> <20180112015231.GA44418@otc-nc-03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: > On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: > >> > >> What's wrong with native_read_msr()? > > > > Yes, i think i should have added to msr.h. The names didn't read as a > > pair, one was native_read_msr, wrmsrl could be taken over when paravirt is > > defined? > > Why do you need to override paravirt? The idea was since these MSR's are passed through we shouldn't need to handle them any differently. Also its best to do this as soon as possible and avoid longer paths to get this barrier to hardware.