Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbeALFD7 (ORCPT + 1 other); Fri, 12 Jan 2018 00:03:59 -0500 Received: from mga02.intel.com ([134.134.136.20]:26891 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbeALFD6 (ORCPT ); Fri, 12 Jan 2018 00:03:58 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; d="scan'208";a="19484857" Subject: Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl To: "Raj, Ashok" , Andy Lutomirski References: <1515720739-43819-1-git-send-email-ashok.raj@intel.com> <1515720739-43819-2-git-send-email-ashok.raj@intel.com> <20180112015231.GA44418@otc-nc-03> <20180112030139.GA46095@otc-nc-03> Cc: LKML , Thomas Gleixner , Tim Chen , Linus Torvalds , Greg KH , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , David Woodhouse , Peter Zijlstra , Dan Williams , Paolo Bonzini , Jun Nakajima , Asit Mallick From: Dave Hansen Message-ID: <917cf067-c986-a459-ea87-7b7724c3c2d6@intel.com> Date: Thu, 11 Jan 2018 21:03:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180112030139.GA46095@otc-nc-03> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11/2018 07:01 PM, Raj, Ashok wrote: > On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: >> On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: >>>> >>>> What's wrong with native_read_msr()? >>> >>> Yes, i think i should have added to msr.h. The names didn't read as a >>> pair, one was native_read_msr, wrmsrl could be taken over when paravirt is >>> defined? >> >> Why do you need to override paravirt? > > The idea was since these MSR's are passed through we shouldn't need to > handle them any differently. Also its best to do this as soon as possible > and avoid longer paths to get this barrier to hardware. We were also worried about the indirect calls that are part of the paravirt interfaces when retpolines are not in place.