Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584AbeALHqE convert rfc822-to-8bit (ORCPT + 1 other); Fri, 12 Jan 2018 02:46:04 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:12421 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754522AbeALHqD (ORCPT ); Fri, 12 Jan 2018 02:46:03 -0500 From: Loic PALLARDY To: Bjorn Andersson CC: "ohad@wizery.com" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , "benjamin.gaignard@linaro.org" Subject: RE: [PATCH v2 03/16] remoteproc: introduce rproc_add_carveout function Thread-Topic: [PATCH v2 03/16] remoteproc: introduce rproc_add_carveout function Thread-Index: AQHTafrejDYgzAOjVUyATBdSN8gEIaNCAn6AgC4b1tA= Date: Fri, 12 Jan 2018 07:45:52 +0000 Message-ID: References: <1512060411-729-1-git-send-email-loic.pallardy@st.com> <1512060411-729-4-git-send-email-loic.pallardy@st.com> <20171214003641.GE17344@builder> In-Reply-To: <20171214003641.GE17344@builder> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-12_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org] > Sent: Thursday, December 14, 2017 1:37 AM > To: Loic PALLARDY > Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux- > kernel@vger.kernel.org; Arnaud POULIQUEN ; > benjamin.gaignard@linaro.org > Subject: Re: [PATCH v2 03/16] remoteproc: introduce rproc_add_carveout > function > > On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > > diff --git a/drivers/remoteproc/remoteproc_core.c > b/drivers/remoteproc/remoteproc_core.c > > index f23daf9..279320a 100644 > > --- a/drivers/remoteproc/remoteproc_core.c > > +++ b/drivers/remoteproc/remoteproc_core.c > > @@ -737,6 +737,7 @@ static int rproc_handle_carveout(struct rproc > *rproc, > > carveout->dma = dma; > > carveout->da = rsc->da; > > carveout->release = rproc_release_carveout; > > + carveout->priv = (void *)CARVEOUT_RSC_ALLOCATED; > > I don't fancy the (ab)use of priv to keep track of this, I also don't > see that it's ever used. Please drop it. It was to distinguish carveout defined from resource table and carveout registered by driver. But agree about priv field usage > > [..] > > +int rproc_add_carveout(struct rproc *rproc, struct rproc_mem_entry > *mem) > > +{ > > + if (!rproc || !mem) > > + return -EINVAL; > > I don't see this function doing more than adding the item to the list of > carveouts, which can't fail. So let's just rely on the user calling it > with valid references and make it return void. Ok > > > + > > + mem->priv = (void *)CARVEOUT_EXTERNAL; > > + > > + list_add_tail(&mem->node, &rproc->carveouts); > > + > > + return 0; > > +} > > +EXPORT_SYMBOL(rproc_add_carveout); > > Regards, > Bjorn