Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbeALH5Z (ORCPT + 1 other); Fri, 12 Jan 2018 02:57:25 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:4186 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754576AbeALH5Y (ORCPT ); Fri, 12 Jan 2018 02:57:24 -0500 From: Xiongfeng Wang To: , , , CC: , Subject: [PATCH] drm/nouveau/core/client: use strlcpy() instead of strncpy() Date: Fri, 12 Jan 2018 16:03:29 +0800 Message-ID: <1515744209-136099-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Xiongfeng Wang gcc-8 reports drivers/gpu/drm/nouveau/nvif/client.c: In function 'nvif_client_init': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 32 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make sure the dest string is nul-terminated. Signed-off-by: Xiongfeng Wang --- drivers/gpu/drm/nouveau/nvif/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvif/client.c b/drivers/gpu/drm/nouveau/nvif/client.c index 12db549..f294d99 100644 --- a/drivers/gpu/drm/nouveau/nvif/client.c +++ b/drivers/gpu/drm/nouveau/nvif/client.c @@ -69,7 +69,7 @@ } nop = {}; int ret; - strncpy(args.name, name, sizeof(args.name)); + strlcpy(args.name, name, sizeof(args.name)); ret = nvif_object_init(parent != client ? &parent->object : NULL, 0, NVIF_CLASS_CLIENT, &args, sizeof(args), &client->object); -- 1.8.3.1