Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbeALIMd (ORCPT + 1 other); Fri, 12 Jan 2018 03:12:33 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33260 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754365AbeALIMc (ORCPT ); Fri, 12 Jan 2018 03:12:32 -0500 Subject: Re: [PATCH 0/2] blk-mq: support physical CPU hotplug To: Ming Lei , Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig Cc: Stefan Haberland , Thomas Gleixner , linux-kernel@vger.kernel.org References: <20180112025306.28004-1-ming.lei@redhat.com> From: Christian Borntraeger Date: Fri, 12 Jan 2018 09:12:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180112025306.28004-1-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18011208-0008-0000-0000-000004C0EF27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011208-0009-0000-0000-00001E544D60 Message-Id: <64c62449-27d2-a0a1-c7db-d2d08a3eb893@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-12_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801120110 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: I think we also need cc stable for this. The bug was introduced with commit 4b855ad37194f7bdbb200ce7a1c7051fecb56a08 upstream. ("blk-mq: Create hctx for each present CPU") and that was even backported into 4.12 stable. On 01/12/2018 03:53 AM, Ming Lei wrote: > Hi, > > This two patches support physical CPU hotplug, so that we can make blk-mq > scale well when new physical CPU is added or removed, and this use case > is normal for VM world. > > Also this patchset fixes the following warning reported by Christian > Borntraeger: > > https://marc.info/?l=linux-block&m=151092973417143&w=2 > > Christoph Hellwig (2): > genirq/affinity: assign vectors to all possible CPUs > blk-mq: simplify queue mapping & schedule with each possisble CPU > > block/blk-mq.c | 19 ++++++++----------- > kernel/irq/affinity.c | 30 +++++++++++++++--------------- > 2 files changed, 23 insertions(+), 26 deletions(-) >