Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754805AbeALIsA (ORCPT + 1 other); Fri, 12 Jan 2018 03:48:00 -0500 Received: from mail-vk0-f66.google.com ([209.85.213.66]:42815 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933457AbeALIrj (ORCPT ); Fri, 12 Jan 2018 03:47:39 -0500 X-Google-Smtp-Source: ACJfBosBFnzQcKGYjLza18rHHhv4GgamjBwEu9QFcnXtycUbDX5MmPTu5JiSCN3fd7Ofu6amQrHMyVVPwTIZZ4vTKcs= MIME-Version: 1.0 In-Reply-To: References: <1507482683-22651-1-git-send-email-ulfalizer@gmail.com> <1507482683-22651-6-git-send-email-ulfalizer@gmail.com> From: Ulf Magnusson Date: Fri, 12 Jan 2018 09:47:38 +0100 Message-ID: Subject: Re: [PATCH 5/6] kconfig: Don't leak help strings during parsing To: Masahiro Yamada Cc: "Yann E. MORIN" , Linux Kbuild mailing list , Sam Ravnborg , zippel@linux-m68k.org, Nicolas Pitre , Michal Marek , dirk@gouders.net, Arnaud Lacombe , walch.martin@web.de, Jan Beulich , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 5:12 PM, Masahiro Yamada wrote: > 2017-10-09 2:11 GMT+09:00 Ulf Magnusson : >> This is just for completeness to get rid of the last memory leak >> currently generated during parsing for ARCH=x86. The symbol >> DVB_NETUP_UNIDVB in drivers/media/pci/netup_unidvb/Kconfig currently has >> two help strings, and we leak the first one. > > Looks like it was fixed by > 561b29e4ec8d0aac7e094f70d649ee4abccdda03 > > > >> Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix: >> >> LEAK SUMMARY: >> definitely lost: 344,440 bytes in 14,350 blocks >> ... >> >> Summary after the fix: >> >> LEAK SUMMARY: >> definitely lost: 344,376 bytes in 14,349 blocks >> ... >> >> Signed-off-by: Ulf Magnusson >> --- >> scripts/kconfig/zconf.y | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y >> index 468ab03..3c9f436 100644 >> --- a/scripts/kconfig/zconf.y >> +++ b/scripts/kconfig/zconf.y >> @@ -435,6 +435,9 @@ help_start: T_HELP T_EOL >> >> help: help_start T_HELPTEXT >> { >> + if (current_entry->help) >> + /* Weird menu node with two help strings */ >> + free(current_entry->help); >> current_entry->help = $2; >> }; > > > I applied this, but maybe is it better to warning message? > zconfprint("warning: ...") or zconf_error()? > > > If you send v2, I will replace this. Yeah, that's a good idea. New version at https://marc.info/?l=linux-kernel&m=151573969713437&w=2. The warning seems more important than the leak, so I rephrased it a bit. Cheers, Ulf