Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933286AbeALKhf convert rfc822-to-8bit (ORCPT + 1 other); Fri, 12 Jan 2018 05:37:35 -0500 Received: from mga02.intel.com ([134.134.136.20]:45509 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754749AbeALKhc (ORCPT ); Fri, 12 Jan 2018 05:37:32 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,348,1511856000"; d="scan'208";a="193334646" From: "Kumar, Abhijeet" To: Takashi Iwai CC: "Koul, Vinod" , "alsa-devel@alsa-project.org" , Liam Girdwood , "Singh, Guneshwor O" , "Kp, Jeeja" , "Tayal, SandeepX" , "Prusty, Subhransu S" , Mark Brown , "Jaroslav Kysela" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output widget power state Thread-Topic: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output widget power state Thread-Index: AQHTis8A+CSLw3QwWEyDXE+e0urW76NvNbIAgACIswD//7SigIAAl9bg Date: Fri, 12 Jan 2018 10:37:28 +0000 Message-ID: <60213CA7255C53479ADE3BCF0360117F02E7124F@PGSMSX104.gar.corp.intel.com> References: <1515670468-9198-1-git-send-email-abhijeet.kumar@intel.com> <20180112054638.GL18649@localhost> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTg5NmZjNTAtNWU3OS00YjRjLWFhMWMtMDNhMjg2YTBiOGMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ6R00wMGNObmZmRGwrcGxcL1JMUW1mMFAzSk54WWd0WGpJekhFZDdpUWdcL3J5VEk3aGEza1J4bTh5bnEwMjdwMEEifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > It's better, but doesn't guarantee that the node reached the given power state. codec_read assures that the verb is sent and the codec gives the response. But it means only the target state gets updated, and doesn't mean that the actual state reached. Thanks Takashi for replying. I guess, I should make use of return value from codec_read and retry if power state is not set properly! I'll make those changes and update again. And just wondering, how does hdmi_codec_prepare() and hdmi_codec_complete() gurantee while powering up and down the afg ? Warm Regards, Abhijeet