Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933380AbeALLXz (ORCPT + 1 other); Fri, 12 Jan 2018 06:23:55 -0500 Received: from mail-ua0-f195.google.com ([209.85.217.195]:39988 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932740AbeALLXx (ORCPT ); Fri, 12 Jan 2018 06:23:53 -0500 X-Google-Smtp-Source: ACJfBoujKnrVfdnIJaMQRpELa59ctXxs8hSukX/uV2fXaVKhBYuD2UOiRqEKReUcaacScAGHYbbIRObIdLsNmiah0yE= MIME-Version: 1.0 In-Reply-To: References: <1507172808-12246-1-git-send-email-ulfalizer@gmail.com> From: Ulf Magnusson Date: Fri, 12 Jan 2018 12:23:52 +0100 Message-ID: Subject: Re: [PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped To: Masahiro Yamada Cc: "Yann E. MORIN" , Linux Kbuild mailing list , Michal Marek , Arnaud Lacombe , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Dec 12, 2017 at 3:58 PM, Masahiro Yamada wrote: > 2017-10-05 12:06 GMT+09:00 Ulf Magnusson : >> Looks like a change to a comment in zconf.y was never committed, because >> the updated version only appears it zconf.tab.c_shipped. Update the >> comment in zconf.y to match. >> >> Signed-off-by: Ulf Magnusson >> --- >> scripts/kconfig/zconf.y | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y >> index c8f396c..4b2cf41 100644 >> --- a/scripts/kconfig/zconf.y >> +++ b/scripts/kconfig/zconf.y >> @@ -101,7 +101,7 @@ static struct menu *current_menu, *current_entry; >> } if_entry menu_entry choice_entry >> >> %{ >> -/* Include zconf_id.c here so it can see the token constants. */ >> +/* Include kconf_id.c here so it can see the token constants. */ >> #include "kconf_id.c" >> %} > > > Applied to linux-kbuild/kconfig. > Thanks! > > BTW, I do not know the historical reason > why zconf instead of kconf in the first place... I have no idea either. kconfig.{l,y} and kconfig_*() would be a lot less confusing. Cheers, Ulf