Date: Fri, 12 Jan 2018 11:50:52 +0000
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Doug Anderson <dianders@google.com>,
        Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Brian Norris <briannorris@google.com>,
        Guenter Roeck <groeck@google.com>,
        Lee Jones <lee.jones@linaro.org>,
        Alexandru Stan <amstan@google.com>, linux-leds@vger.kernel.org,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] backlight: pwm_bl: compute brightness of LED
 linearly to human eye.
Message-ID: <20180112115052.GB3642@birch.example.com>
References: <20180110223046.17696-1-enric.balletbo@collabora.com>
 <20180110223046.17696-4-enric.balletbo@collabora.com>
 <CAFqH_50zs+TMZaRNegxYPQOcysvwm9EY5iB8DqNeGYN+QaJP6Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFqH_50zs+TMZaRNegxYPQOcysvwm9EY5iB8DqNeGYN+QaJP6Q@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Jan 12, 2018 at 11:14:54AM +0100, Enric Balletbo Serra wrote:
> > @@ -441,6 +544,26 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> >         dev_dbg(&pdev->dev, "got pwm for backlight\n");
> >
> > +       if (!data->levels) {
> > +               /* Get the PWM period (in nanoseconds) */
> > +               pwm_get_state(pb->pwm, &state);
> > +
> > +               ret = pwm_backlight_brightness_default(&pdev->dev, data,
> > +                                                      state.period);
> > +               if (ret < 0) {
> > +                       dev_err(&pdev->dev,
> > +                               "failed to setup default brightness table\n");
> > +                       goto err_alloc;
> > +               }
> > +       }
> > +
> > +       for (i = 0; i <= data->max_brightness; i++)
> 
> Oops, horrible and unjustifiable mistake, missing { here :/

Well, at least you found it rather than us :-)


Daniel.