Date: Fri, 12 Jan 2018 16:18:47 +0000
From: Ayan Halder <ayan.halder@arm.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Ville Syrj?l? <ville.syrjala@linux.intel.com>, nd@arm.com,
        airlied@linux.ie, liviu.dudau@arm.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        daniel.vetter@intel.com
Subject: Re: [PATCH] drm: add drm_format_alpha_bits
Message-ID: <20180112161847.GB18191@arm.com>
References: <1515766876-14231-1-git-send-email-ayan.halder@arm.com>
 <20180112142834.GB10981@intel.com>
 <20180112154349.GE16548@arm.com>
 <20180112155116.bqpyreloi6dkmqv3@flea.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180112155116.bqpyreloi6dkmqv3@flea.lan>
User-Agent: Mutt/1.5.24 (2015-08-30)
NoDisclaimer: True
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2018 16:18:49.6999 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8adbf929-b9e6-49a4-03f6-08d559d82a35
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2411
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Fri, Jan 12, 2018 at 04:51:16PM +0100, Maxime Ripard wrote:
> Hi,
> 
> On Fri, Jan 12, 2018 at 03:43:49PM +0000, Ayan Halder wrote:
> > On Fri, Jan 12, 2018 at 04:28:34PM +0200, Ville Syrj?l? wrote:
> > > On Fri, Jan 12, 2018 at 02:21:16PM +0000, Ayan Halder wrote:
> > > > drm_format_info does not describe the number of bits used for the alpha
> > > > channel. That information is useful in a central place like drm_fourcc.c
> > > > where it can be queried by the drivers that want to determine if 'alpha
> > > > blending' is to be enabled or not.
> > > > 
> > > > Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com>
> > > > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> > > > ---
> > > >  drivers/gpu/drm/drm_fourcc.c | 154 ++++++++++++++++++++++++-------------------
> > > >  include/drm/drm_fourcc.h     |   3 +
> > > >  2 files changed, 89 insertions(+), 68 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
> > > > index 9c0152d..073001b 100644
> > > > --- a/drivers/gpu/drm/drm_fourcc.c
> > > > +++ b/drivers/gpu/drm/drm_fourcc.c
> > > <snip>
> > > > @@ -348,3 +348,21 @@ int drm_format_plane_height(int height, uint32_t format, int plane)
> > > >  	return height / info->vsub;
> > > >  }
> > > >  EXPORT_SYMBOL(drm_format_plane_height);
> > > > +
> > > > +/**
> > > > + * drm_format_alpha_bits - get the number of bits per pixel
> > > > + * representing alpha for format
> > > > + * @format: pixel format (DRM_FORMAT_*)
> > > > + *
> > > > + * Returns:
> > > > + * The number of bits per pixel representing alpha used by the
> > > > + * specified pixel format.
> > > > + */
> > > > +int drm_format_alpha_bits(uint32_t format)
> > > > +{
> > > > +	const struct drm_format_info *info;
> > > > +
> > > > +	info = drm_format_info(format);
> > > > +	return info ? info->alpha : 0;
> > > > +}
> > > > +EXPORT_SYMBOL(drm_format_alpha_bits);
> > > 
> > > Do you have an actual use for this function somewhere?
> >
> > Currently, we do not have a usage for this function. We need 'alpha'
> > field for each entry in 'drm_format_info' so as to determine whether
> > to enable/disable alpha blending in Mali display processor for the
> > particular color format.
> 
> Do you need only the info that a particular channel has an alpha
> component, or do you also need the number of bits?

Currently, only the info whether alpha component is present in a
particular channel. I saw your patch and thought that instead of
returning true/false, it might be useful to capture the number of
alpha bits for each format.
> In the former case, then my serie sent earlier this week would help I
> guess.
> 
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com