Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965178AbeALSKd (ORCPT + 1 other); Fri, 12 Jan 2018 13:10:33 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38424 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965105AbeALSKb (ORCPT ); Fri, 12 Jan 2018 13:10:31 -0500 Subject: Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling To: Dong Jia Shi , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: cohuck@redhat.com, borntraeger@de.ibm.com, pmorel@linux.vnet.ibm.com References: <20180111030421.31418-1-bjsdjshi@linux.vnet.ibm.com> From: Halil Pasic Date: Fri, 12 Jan 2018 19:10:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180111030421.31418-1-bjsdjshi@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18011218-0012-0000-0000-000005A31633 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011218-0013-0000-0000-0000191E7EC9 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-12_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801120246 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11/2018 04:04 AM, Dong Jia Shi wrote: > What are still missing, thus need to be offered in the next version are: > - I/O termination and FSM state handling if currently we have I/O on the status > switched path. > - Vary on/off event is not sensible to a guest. I don't see a doc update. We do have documentation (in Documentation/s390/vfio-ccw.txt) in which the uapi interface with the regions and their purpose/usage is at least kind of explained. You are changing this interface without updating the doc. I would like to see documentation on this because I'm under the impression either the design is pretty convoluted or I did not get it at all. Regards, Halil