Date: Fri, 12 Jan 2018 14:18:13 -0500
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Chris Metcalf <cmetcalf@mellanox.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Christoph Lameter <cl@linux.com>,
        "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
        Wanpeng Li <kernellwp@gmail.com>,
        Mike Galbraith <efault@gmx.de>, Rik van Riel <riel@redhat.com>
Subject: Re: [GIT PULL] isolation: 1Hz residual tick offloading v3
Message-ID: <20180112141813.32dcc84d@redhat.com>
In-Reply-To: <1515039937-367-1-git-send-email-frederic@kernel.org>
References: <1515039937-367-1-git-send-email-frederic@kernel.org>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Thu,  4 Jan 2018 05:25:32 +0100
Frederic Weisbecker <frederic@kernel.org> wrote:

> Ingo,
> 
> Please pull the sched/0hz branch that can be found at:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	sched/0hz
> 
> HEAD: 9e932b2cc707209febd130978a5eb9f4a943a3f4
> 
> --
> Now that scheduler_tick() has become resilient towards the absence of
> ticks, current->sched_class->task_tick() is the last piece that needs
> at least 1Hz tick to keep scheduler stats alive.
> 
> This patchset adds a flag to the isolcpus boot option to offload the
> residual 1Hz tick. This way the nohz_full CPUs don't have anymore tick
> (assuming nothing else requires it) as their residual 1Hz tick is
> offloaded to the housekeepers.
> 
> For quick testing, say on CPUs 1-7:
> 
> 	"isolcpus=nohz_offload,domain,1-7"

Sorry for being very late to this series, but I've a few comments to
make (one right now and others in individual patches).

Why are extending isolcpus= given that it's a deprecated interface?
Some people have already moved away from isolcpus= now, but with this
new feature they will be forced back to using it.

What about just adding the new functionality to nohz_full=? That is,
no new options, just make the tick go away since this has always been
what nohz_full= was intended to do?

> 
> Thanks,
> 	Frederic
> ---
> 
> Frederic Weisbecker (5):
>       sched: Rename init_rq_hrtick to hrtick_rq_init
>       sched/isolation: Add scheduler tick offloading interface
>       nohz: Allow to check if remote CPU tick is stopped
>       sched/isolation: Residual 1Hz scheduler tick offload
>       sched/isolation: Document "nohz_offload" flag
> 
> 
>  Documentation/admin-guide/kernel-parameters.txt |  7 +-
>  include/linux/sched/isolation.h                 |  3 +-
>  include/linux/tick.h                            |  2 +
>  kernel/sched/core.c                             | 94 +++++++++++++++++++++++--
>  kernel/sched/isolation.c                        | 10 +++
>  kernel/sched/sched.h                            |  2 +
>  kernel/time/tick-sched.c                        |  7 ++
>  7 files changed, 117 insertions(+), 8 deletions(-)
>