Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965313AbeALWfZ (ORCPT + 1 other); Fri, 12 Jan 2018 17:35:25 -0500 Received: from mail.ispras.ru ([83.149.199.45]:49504 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965242AbeALWfY (ORCPT ); Fri, 12 Jan 2018 17:35:24 -0500 From: Alexey Khoroshilov To: Mats Randgaard , Mauro Carvalho Chehab Cc: Alexey Khoroshilov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: media: tc358743: clk_disable_unprepare(refclk) missed Date: Sat, 13 Jan 2018 01:35:03 +0300 Message-Id: <1515796503-21642-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello, tc358743_probe_of() enables refclk and disables it on its error paths. But there is no clk_disable_unprepare(refclk) in tc358743_remove() and on error paths in tc358743_probe(). Is it a problem? If we should fix it, is adding struct clk *refclk; to tc358743_state the reasonable way to keep clk easily available? Found by Linux Driver Verification project (linuxtesting.org). -- Alexey Khoroshilov Linux Verification Center, ISPRAS web: http://linuxtesting.org