Date: Sat, 13 Jan 2018 11:21:43 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Andrea Arcangeli <aarcange@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Pavel Emelyanov <xemul@parallels.com>,
        Hillf Danton <hillf.zj@alibaba-inc.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Sasha Levin <alexander.levin@verizon.com>
Subject: Re: [PATCH 4.4 020/115] userfaultfd: selftest: vm: allow to build in
 vm/ directory
Message-ID: <20180113102143.GA7558@kroah.com>
References: <20171218152851.886086917@linuxfoundation.org>
 <20171218152853.415490755@linuxfoundation.org>
 <1515699768.12097.18.camel@codethink.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1515699768.12097.18.camel@codethink.co.uk>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Jan 11, 2018 at 07:42:48PM +0000, Ben Hutchings wrote:
> On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.??If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Andrea Arcangeli <aarcange@redhat.com>
> > 
> > 
> > [ Upstream commit 46aa6a302b53f543f8e8b8e1714dc5e449ad36a6 ]
> > 
> > linux/tools/testing/selftests/vm $ make
> > 
> > ? gcc -Wall -I ../../../../usr/include?????compaction_test.c -lrt -o /compaction_test
> > ? /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.4/../../../../x86_64-pc-linux-gnu/bin/ld: cannot open output file /compaction_test: Permission denied
> > ? collect2: error: ld returned 1 exit status
> > ? make: *** [../lib.mk:54: /compaction_test] Error 1
> > 
> > Since commit a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> > selftests/vm build fails if run from the "selftests/vm" directory, but
> > it works in the selftests/ directory.??It's quicker to be able to do a
> > local vm-only build after a tree wipe and this patch allows for it
> > again.
> 
> That commit is not included in 4.4 and nothing under
> tools/testing/selftests uses the OUTPUT variable that this defines.

Ugh, good catch, I'll go revert this.

Sasha, I thought your scripts caught this type of thing?

thanks,

greg k-h