MIME-Version: 1.0
In-Reply-To: <20180113175353.GA3513@himanshu-Vostro-3559>
References: <1515859050-31764-1-git-send-email-himanshujha199640@gmail.com>
 <CAOMZO5C0JEnvCqNejPbVg3DUGxoH9_Gu5Znc0G2BDBWqmgppLw@mail.gmail.com> <20180113175353.GA3513@himanshu-Vostro-3559>
From: Fabio Estevam <festevam@gmail.com>
Date: Sat, 13 Jan 2018 17:13:36 -0200
Message-ID: <CAOMZO5DvY-5kjzD8fKWkR2PhgT3HO7tT_fAZnuomBx+woLqH6g@mail.gmail.com>
Subject: Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple
 to zalloc-simple
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
        michal.lkml@markovi.net, nicolas.palix@imag.fr,
        linux-kernel <linux-kernel@vger.kernel.org>,
        cocci@systeme.lip6.fr
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha
<himanshujha199640@gmail.com> wrote:

> Yes, I used 'git mv'.
>
> It doesn't matter when applying through 'git am', both will result the
> same AFAIK and only difference is that the patch files generated by 'git
> format-patch' are different. But that is not important I think.

You missed the -M option when running 'git format'.

For reviewers it is not that easy to realize that the 448 lines of the
original file are the same as the ones in the new file.

The -M option generates a much cleaner patch.