Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbeAMTdx (ORCPT + 1 other); Sat, 13 Jan 2018 14:33:53 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:45447 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbeAMTdv (ORCPT ); Sat, 13 Jan 2018 14:33:51 -0500 X-Google-Smtp-Source: ACJfBouCxwViUZzTo7lkl3+nKdoYPspzGTBbQDEhSQYpeey+QebSVvf09nQeCLABVWCzLeo3gmXIb1pPaQzlHlJRvIg= MIME-Version: 1.0 In-Reply-To: References: <151586744180.5820.13215059696964205856.stgit@dwillia2-desk3.amr.corp.intel.com> <151586748981.5820.14559543798744763404.stgit@dwillia2-desk3.amr.corp.intel.com> From: Linus Torvalds Date: Sat, 13 Jan 2018 11:33:50 -0800 X-Google-Sender-Auth: WoxGeppzJHpNCsfh7xG6Mq1B_K0 Message-ID: Subject: Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths To: Dan Williams Cc: Linux Kernel Mailing List , linux-arch@vger.kernel.org, Andi Kleen , Kees Cook , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , "the arch/x86 maintainers" , Ingo Molnar , Al Viro , "H. Peter Anvin" , Thomas Gleixner , Andrew Morton , Alan Cox Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat, Jan 13, 2018 at 11:05 AM, Linus Torvalds wrote: > > I _know_ that lfence is expensive as hell on P4, for example. > > Yes, yes, "sbb" is often more expensive than most ALU instructions, > and Agner Fog says it has a 10-cycle latency on Prescott (which is > outrageous, but being one or two cycles more due to the flags > generation is normal). So the sbb/and may certainly add a few cycles > to the critical path, but on Prescott "lfence" is *50* cycles > according to those same tables by Agner Fog. Side note: I don't think P4 is really relevant for a performance discussion, I was just giving it as an example where we do know actual cycles. I'm much more interested in modern Intel big-core CPU's, and just wondering whether somebody could ask an architect. Because I _suspect_ the answer from a CPU architect would be: "Christ, the sbb/and sequence is much better because it doesn't have any extra serialization", but maybe I'm wrong, and people feel that lfence is particularly easy to do right without any real downside. Linus