Date: Sun, 14 Jan 2018 01:22:05 +0530
From: Himanshu Jha <himanshujha199640@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
        michal.lkml@markovi.net, nicolas.palix@imag.fr,
        linux-kernel <linux-kernel@vger.kernel.org>,
        cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename
 kzalloc-simple to zalloc-simple
Message-ID: <20180113195205.GB6389@himanshu-Vostro-3559>
References: <1515859050-31764-1-git-send-email-himanshujha199640@gmail.com>
 <CAOMZO5C0JEnvCqNejPbVg3DUGxoH9_Gu5Znc0G2BDBWqmgppLw@mail.gmail.com>
 <20180113175353.GA3513@himanshu-Vostro-3559>
 <CAOMZO5DvY-5kjzD8fKWkR2PhgT3HO7tT_fAZnuomBx+woLqH6g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOMZO5DvY-5kjzD8fKWkR2PhgT3HO7tT_fAZnuomBx+woLqH6g@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org

On Sat, Jan 13, 2018 at 05:13:36PM -0200, Fabio Estevam wrote:
> On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha
> <himanshujha199640@gmail.com> wrote:
> 
> > Yes, I used 'git mv'.
> >
> > It doesn't matter when applying through 'git am', both will result the
> > same AFAIK and only difference is that the patch files generated by 'git
> > format-patch' are different. But that is not important I think.
> 
> You missed the -M option when running 'git format'.
> 
> For reviewers it is not that easy to realize that the 448 lines of the
> original file are the same as the ones in the new file.
> 
> The -M option generates a much cleaner patch.

I guess you're right because patch has many lines.
No problem, I will send again with a much cleaner patch. :-)

-- 
Thanks
Himanshu Jha