Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751838AbeANNSw (ORCPT + 1 other); Sun, 14 Jan 2018 08:18:52 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:36702 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbeANNSv (ORCPT ); Sun, 14 Jan 2018 08:18:51 -0500 From: OGAWA Hirofumi To: ChenGuanqiao Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/3] fs: fat: Add fat filesystem partition volume label in local structure References: <20180110102153.12388-1-chen.chenchacha@foxmail.com> <20180110102153.12388-2-chen.chenchacha@foxmail.com> Date: Sun, 14 Jan 2018 22:18:48 +0900 In-Reply-To: <20180110102153.12388-2-chen.chenchacha@foxmail.com> (ChenGuanqiao's message of "Wed, 10 Jan 2018 18:21:51 +0800") Message-ID: <87wp0kd1dz.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: ChenGuanqiao writes: > Signed-off-by: ChenGuanqiao > --- > fs/fat/fat.h | 6 ++++++ > fs/fat/inode.c | 15 ++++++++++++--- > include/uapi/linux/msdos_fs.h | 2 ++ > 3 files changed, 20 insertions(+), 3 deletions(-) > > diff --git a/fs/fat/fat.h b/fs/fat/fat.h > index 8fc1093da47d..96f631282c71 100644 > --- a/fs/fat/fat.h > +++ b/fs/fat/fat.h > @@ -86,6 +86,7 @@ struct msdos_sb_info { > int dir_per_block; /* dir entries per block */ > int dir_per_block_bits; /* log2(dir_per_block) */ > unsigned int vol_id; /*volume ID*/ > + char vol_label[11]; /*volume label*/ In latter patches doesn't use this cache. Why do we cache, or why read ioctl doesn't use this cache? -- OGAWA Hirofumi