Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbeANPCl (ORCPT + 1 other); Sun, 14 Jan 2018 10:02:41 -0500 Received: from mail.skyhub.de ([5.9.137.197]:36686 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbeANPCk (ORCPT ); Sun, 14 Jan 2018 10:02:40 -0500 Date: Sun, 14 Jan 2018 16:02:19 +0100 From: Borislav Petkov To: Josh Poimboeuf Cc: David Woodhouse , Andi Kleen , Paul Turner , LKML , Linus Torvalds , Greg Kroah-Hartman , Tim Chen , Dave Hansen , tglx@linutronix.de, Kees Cook , Rik van Riel , Peter Zijlstra , Andy Lutomirski , Jiri Kosina , gnomes@lxorguk.ukuu.org.uk, x86@kernel.org, thomas.lendacky@amd.com Subject: Re: [PATCH v8 03/12] x86/retpoline: Add initial retpoline support Message-ID: <20180114150219.olnya5vlgjbmbcbr@pd.tnic> References: <1515707194-20531-1-git-send-email-dwmw@amazon.co.uk> <1515707194-20531-4-git-send-email-dwmw@amazon.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1515707194-20531-4-git-send-email-dwmw@amazon.co.uk> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 09:46:25PM +0000, David Woodhouse wrote: > +/* > + * This should be used immediately before a retpoline alternative. It tells > + * objtool where the retpolines are so that it can make sense of the control > + * flow by just reading the original instruction(s) and ignoring the > + * alternatives. > + */ > +.macro ANNOTATE_NOSPEC_ALTERNATIVE > + .Lannotate_\@: > + .pushsection .discard.nospec > + .long .Lannotate_\@ - . > + .popsection > +.endm Hey Josh, what happened to parsing only the retpoline-related .altinstructions sections with the X86_FEATURE bits? Or is this annotation used for something more additionally? Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.