Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbeANTLM (ORCPT + 1 other); Sun, 14 Jan 2018 14:11:12 -0500 Received: from terminus.zytor.com ([65.50.211.136]:48601 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbeANTLL (ORCPT ); Sun, 14 Jan 2018 14:11:11 -0500 Date: Sun, 14 Jan 2018 11:10:02 -0800 From: tip-bot for Andi Kleen Message-ID: Cc: ak@linux.intel.com, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org Reply-To: tglx@linutronix.de, hpa@zytor.com, ak@linux.intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20171222001821.2157-2-andi@firstfloor.org> References: <20171222001821.2157-2-andi@firstfloor.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/cleanups] x86/timer: Don't inline __const_udelay Git-Commit-ID: 7cf1aaa2ad3855bd5e95bef382a66fe122fc9b01 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit-ID: 7cf1aaa2ad3855bd5e95bef382a66fe122fc9b01 Gitweb: https://git.kernel.org/tip/7cf1aaa2ad3855bd5e95bef382a66fe122fc9b01 Author: Andi Kleen AuthorDate: Thu, 21 Dec 2017 16:18:16 -0800 Committer: Thomas Gleixner CommitDate: Sun, 14 Jan 2018 20:03:49 +0100 x86/timer: Don't inline __const_udelay __const_udelay is marked inline, and LTO will happily inline it everywhere Dropping the inline saves ~44k text in a LTO build. 13999560 1740864 1499136 17239560 1070e08 vmlinux-with-udelay-inline 13954764 1736768 1499136 17190668 1064f0c vmlinux-wo-udelay-inline Inlining it has no advantage in general, so its the right thing to do. Signed-off-by: Andi Kleen Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/20171222001821.2157-2-andi@firstfloor.org --- arch/x86/lib/delay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c index 553f8fd..09c83b2 100644 --- a/arch/x86/lib/delay.c +++ b/arch/x86/lib/delay.c @@ -162,7 +162,7 @@ void __delay(unsigned long loops) } EXPORT_SYMBOL(__delay); -inline void __const_udelay(unsigned long xloops) +void __const_udelay(unsigned long xloops) { unsigned long lpj = this_cpu_read(cpu_info.loops_per_jiffy) ? : loops_per_jiffy; int d0;