Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013AbeANX52 (ORCPT + 1 other); Sun, 14 Jan 2018 18:57:28 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:44162 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696AbeANX50 (ORCPT ); Sun, 14 Jan 2018 18:57:26 -0500 X-Google-Smtp-Source: ACJfBotk2IVoC4ITYgtFW5gQPBIogy74Xc5mrmpQPCr8wcKKGlXXJ4UL8jePfRTj118r6HSehk2LqA== Date: Sun, 14 Jan 2018 15:57:21 -0800 From: Nicolin Chen To: "Maciej S. Szmigiero" Cc: timur@tabi.org, broonie@kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, fabio.estevam@nxp.com, caleb@crome.org, arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de Subject: Re: [PATCH v2 03/16] ASoC: fsl_ssi: Maintain a mask of active streams Message-ID: <20180114235720.GA2925@Asurada-CZ80> References: <1515652995-15996-1-git-send-email-nicoleotsuka@gmail.com> <1515652995-15996-4-git-send-email-nicoleotsuka@gmail.com> <1488354c-99b0-fa64-a88c-0fa065df4b7d@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488354c-99b0-fa64-a88c-0fa065df4b7d@maciej.szmigiero.name> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, Jan 14, 2018 at 11:34:01PM +0100, Maciej S. Szmigiero wrote: > > + bool dir = (&ssi->regvals[TX] == vals) ? TX : RX; > Using a bool variable for a bit index (and array index in other parts > of code) looks just wrong. > > Even a simple int would look better IMHO here (and in patch 5 that > rewrites this line a bit). Will change to int. Thanks