Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbeAOIBn (ORCPT + 1 other); Mon, 15 Jan 2018 03:01:43 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:40332 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbeAOIBl (ORCPT ); Mon, 15 Jan 2018 03:01:41 -0500 Date: Mon, 15 Jan 2018 09:01:39 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2] arm64: allwinner: a64: orangepi-zero-plus2: add usb otg Message-ID: <20180115080139.k2vrczo3hnvdt3df@flea.lan> References: <1515748144-25204-1-git-send-email-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p6rafjyb3xdq3bfv" Content-Disposition: inline In-Reply-To: <1515748144-25204-1-git-send-email-jagan@amarulasolutions.com> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --p6rafjyb3xdq3bfv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jan 12, 2018 at 02:39:04PM +0530, Jagan Teki wrote: > Add usb otg support for orangepi-zero-plus2 board: > - Add usb_otg node with dr_mode as 'otg' > - USB0-IDDET connected to PA21 > - VBUS connected through DCIN which always on >=20 > Tested mass storage function. >=20 > Signed-off-by: Jagan Teki > --- > Changes for v2: > - Change dr_mode to peripheral >=20 > .../dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts | 18 ++++++++++++= ++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.= dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts > index af43533..6511190 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts > @@ -73,6 +73,10 @@ > }; > }; > =20 > +&ehci0 { > + status =3D "okay"; > +}; > + > &mmc0 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&mmc0_pins_a>; > @@ -111,6 +115,10 @@ > status =3D "okay"; > }; > =20 > +&ohci0 { > + status =3D "okay"; > +}; > + > &uart0 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&uart0_pins_a>; > @@ -122,3 +130,13 @@ > pinctrl-0 =3D <&uart1_pins>, <&uart1_rts_cts_pins>; > status =3D "okay"; > }; > + > +&usb_otg { > + dr_mode =3D "peripheral"; If VBUS is always on, this can only operate safely in host mode, not peripheral. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --p6rafjyb3xdq3bfv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlpcX+IACgkQ0rTAlCFN r3SyuQ//S0L81FIIeoTWgEWHPisbTPiDVqTigfEuWeZT6xDt6Wcj5fVOtcJeeNNo J1xqN68NkDAVmgmrNmKs8AT/fFcILQdcPWmzzv/IsCqGSDXx12xnJj6BFna0xyiX V29UDI3DTPBYKH2AUiBNOZEilbbXoX2IEE3YU0M0fntSxu4Elf4a9cf1PXWEkYcI ANBaFFg4McYDVisdG/bxRhY5wJrkdVc/ZQgMwlX/lD/0G6kQr+kQN4aScdzorqwv pTaO89vfEZW+Y4Bzx8NunM7piXpCgr5sOxuRTAwMk0/BWbgPNBcnCmhrmHpfHv06 ukkOhBcEohF7IHGpahIepUBayQaAU5aKDpsE0l5WQ4t1I7GoyENWuLkIJfdixCRT RrRMvMeRWCnPBqM6FXl+7XLWmXxyd+8lnLuPyp1Z+XrH397lQFhbCxWydBQQxEHU 9s42BnrCz30VBwTGspW1KMvUuS7dsB3yykpeWAY+hMcJYYYeSGTd1jOim4Ge+UWW QuTKK3oLE5J0oxEAE95czUbw+2kX+2L9EJD+E7e93oXJ4cw8zCNJmE3Q3ndCL65s oVXefaNOL8yNYgZxhucibNSAN2ei2twHMn7VxAAP2X17BIsKJbeWo8taMzQ1abmK S8CceqfgDC4W4V3o6YfD9qNoZhdoT3L/bnu1HS2bqtQzwgUEfMA= =zP+b -----END PGP SIGNATURE----- --p6rafjyb3xdq3bfv--