Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932389AbeAOIyT (ORCPT + 1 other); Mon, 15 Jan 2018 03:54:19 -0500 Received: from verein.lst.de ([213.95.11.211]:39462 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754504AbeAOIyS (ORCPT ); Mon, 15 Jan 2018 03:54:18 -0500 Date: Mon, 15 Jan 2018 09:54:16 +0100 From: Christoph Hellwig To: Jeff Moyer Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 30/32] aio: add delayed cancel support Message-ID: <20180115085416.GC32532@lst.de> References: <20180110155853.32348-1-hch@lst.de> <20180110155853.32348-31-hch@lst.de> <20180111134358.GA5926@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 10:27:05AM -0500, Jeff Moyer wrote: > Duh, good point. My main concern is that things like usb gadget will > have to deal with races between cancellation and completion on their > own. It would be nice if we had infrastructure for them to use. I'll > have a look through that code to see if there's something we could or > should be doing. The current cancel interface is a bit of a mess, as it assumes the kiocb is embedded into an aio_kiocb. I think it would need a major rework in general, but I'll need to fix a couple other aio issues first.