Subject: Re: hyperv/netvsc: Delete two error messages for a failed memory
 allocation in netvsc_init_buf()
To: Haiyang Zhang <haiyangz@microsoft.com>,
        devel@linuxdriverproject.org, netdev@vger.kernel.org
Cc: KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <bb8fac96-9ba6-e54f-2321-72a8fba90085@users.sourceforge.net>
 <CY4PR2101MB0867CEFAF4FB72AF47FA3AA7CA130@CY4PR2101MB0867.namprd21.prod.outlook.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c7ffcb1d-107c-c49b-b3bf-9b0f260e7214@users.sourceforge.net>
Date: Mon, 15 Jan 2018 10:00:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <CY4PR2101MB0867CEFAF4FB72AF47FA3AA7CA130@CY4PR2101MB0867.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

> These messages are not displayed anywhere else:
> "unable to allocate receive buffer of size %u\n"
> "unable to allocate send buffer of size %u\n",
> 
> After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation failed without the error message.

How do you think about to achieve the distinction for these buffers by any other means?

Can a detailed function call stack dump be appropriate?


> So please do not remove these messages.

Would you dare to adjust this function implementation in any other ways?

Regards,
Markus