Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933209AbeAOJvR (ORCPT + 1 other); Mon, 15 Jan 2018 04:51:17 -0500 Received: from 3.mo177.mail-out.ovh.net ([46.105.36.172]:60122 "EHLO 3.mo177.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488AbeAOJvQ (ORCPT ); Mon, 15 Jan 2018 04:51:16 -0500 Subject: Re: [PATCH] powerpc/xive: Properly use static keyword for inline function To: Mathieu Malaterre Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List References: <20171226130020.23626-1-malat@debian.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <24525a62-208e-b30e-6a53-0f97a2a8fae7@kaod.org> Date: Mon, 15 Jan 2018 10:51:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20171226130020.23626-1-malat@debian.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 8760064228582394647 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtuddrleekgddtjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 12/26/2017 02:00 PM, Mathieu Malaterre wrote: > Fix fatal warning during compilation: > > In file included from arch/powerpc/xmon/xmon.c:54:0: > ./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes] > extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } > ^ > > Signed-off-by: Mathieu Malaterre Reviewed-by: Cédric Le Goater Thanks, C. > --- > arch/powerpc/include/asm/xive.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h > index 371fbebf1ec9..83dc2cc320a3 100644 > --- a/arch/powerpc/include/asm/xive.h > +++ b/arch/powerpc/include/asm/xive.h > @@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; } > static inline bool xive_spapr_init(void) { return false; } > static inline bool xive_native_init(void) { return false; } > static inline void xive_smp_probe(void) { } > -extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } > +static inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } > static inline void xive_smp_setup_cpu(void) { } > static inline void xive_smp_disable_cpu(void) { } > static inline void xive_kexec_teardown_cpu(int secondary) { } >