Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934037AbeAOKgD (ORCPT + 1 other); Mon, 15 Jan 2018 05:36:03 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:4222 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932231AbeAOKgB (ORCPT ); Mon, 15 Jan 2018 05:36:01 -0500 From: Wei Yongjun To: James Morse , Catalin Marinas CC: Wei Yongjun , , , Subject: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt() Date: Mon, 15 Jan 2018 10:41:53 +0000 Message-ID: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: In case of error, the function of_platform_device_create() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 677a60bd2003 ("firmware: arm_sdei: Discover SDEI support via ACPI") Signed-off-by: Wei Yongjun --- drivers/firmware/arm_sdei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 8f6563c..1ea7164 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -1023,7 +1023,7 @@ static bool __init sdei_present_dt(void) pdev = of_platform_device_create(np, sdei_driver.driver.name, NULL); of_node_put(np); - if (IS_ERR(pdev)) + if (!pdev) return false; return true;