Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755425AbeAOKk0 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 15 Jan 2018 05:40:26 -0500
Received: from foss.arm.com ([217.140.101.70]:38410 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754265AbeAOKkY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Jan 2018 05:40:24 -0500
Message-ID: <5A5C848E.70304@arm.com>
Date: Mon, 15 Jan 2018 10:38:06 +0000
From: James Morse <james.morse@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: Wei Yongjun <weiyongjun1@huawei.com>,
        Catalin Marinas <catalin.marinas@arm.com>
CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt()
References: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com>
In-Reply-To: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Hi Wei,

On 15/01/18 10:41, Wei Yongjun wrote:
> In case of error, the function of_platform_device_create() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.

Bother, so it does!

Thanks for catching this.
Acked-by: James Morse <james.morse@arm.com>


Thanks,

James