Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933463AbeAOMbS (ORCPT + 1 other); Mon, 15 Jan 2018 07:31:18 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:41776 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932796AbeAOMbN (ORCPT ); Mon, 15 Jan 2018 07:31:13 -0500 X-Google-Smtp-Source: ACJfBosG26cqkmrYn8Jple6cb3NmJ31KlYiN4RYerQgvTz0NehnnCsyryMvpw/xqs5+WcXQiA1cL9YscEOaDCMZJEQs= MIME-Version: 1.0 X-Originating-IP: [195.166.127.210] In-Reply-To: <20180114105110.14ec8c8f@archlinux> References: <1514556006-23293-1-git-send-email-mastichi@gmail.com> <20171229175449.760e734d@archlinux> <20180101095342.4d4d5325@archlinux> <20180114105110.14ec8c8f@archlinux> From: Javier Martinez Canillas Date: Mon, 15 Jan 2018 13:31:12 +0100 Message-ID: Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading To: Jonathan Cameron Cc: Dmitry Mastykin , Andy Shevchenko , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jacopo Mondi , Dan Carpenter , Rob Herring , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, Jan 14, 2018 at 11:51 AM, Jonathan Cameron wrote: > On Wed, 10 Jan 2018 12:01:07 +0100 > Javier Martinez Canillas wrote: > >> Hello Jonathan, >> >> On Mon, Jan 1, 2018 at 10:53 AM, Jonathan Cameron wrote: >> >> [snip] >> >> > >> > I may well be missing some subtle detail of course having spent only a few >> > minute looking at this! >> > >> >> Your understanding is correct. This change has nothing to do with >> module autoloading. >> >> The .probe_new callback is only used to avoid requiring an I2C device >> ID table since the old .probe callback has a struct i2c_device_id as a >> parameter and so requires a table even in OF (or ACPI) only drivers. > > OK, then let us revisit this patch once we have an answer on your one > fixing the autoprobing more generally. Until we then we don't know > whether we need to add the i2c table in or not whether this suffices. > That's correct. If the driver is for a device that's OF-only (e.g: will never be used from a non-DT platform) then I don't think we should add a I2C table. Now, if Wolfram nacks my patch then we should add it as a workaround to have auto-loading working. > Jonathan > Best regards, Javier