Subject: Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP
To: Ingo Molnar <mingo@kernel.org>, Mike Galbraith <mgalbraith@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Borislav Petkov <bp@alien8.de>
References: <1515675936.7350.15.camel@suse.de>
 <20180111133723.d7x3sekanz5jhut2@gmail.com>
 <1515682631.16805.3.camel@suse.de>
 <20180111150331.7zzkd7awdxele54b@gmail.com>
 <20180111151044.GC6176@hirez.programming.kicks-ass.net>
 <1515694412.7054.10.camel@suse.de> <1515731128.10188.32.camel@suse.de>
 <20180112131144.bkopj2ooslwdyvoz@gmail.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <0af5f083-b659-6c67-1ceb-a2bf9108c879@suse.com>
Date: Mon, 15 Jan 2018 15:52:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180112131144.bkopj2ooslwdyvoz@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

On 12/01/18 14:11, Ingo Molnar wrote:
> 
> * Mike Galbraith <mgalbraith@suse.de> wrote:
> 
>> Hi Juergen,
>>
>> Yesterday I wanted to test the RETPOLINE stuff in tip and tip-rt, but
>> discovered instead that my box had turned into a complete slug, not due
>> to incredible RETPOLINE overhead, rather because box had forgotten that
>> it had more than one CPU.  I was going to leave it for the weekend, but
>> firing up gitk over morning java, I noticed the commits below, and sure
>> enough, that's what broke my box.  Given other people's boxen work,
>> seems likely that the authors of the AMI BIOS in this box were a bit
>> more creative than usual.
>>
>> commit 9ede5d5e672586e016eadd5c0aedb6f12e660029 (HEAD -> x86-tip)
>> Author: Mike Galbraith <mgalbraith@suse.de>
>> Date:   Fri Jan 12 04:17:52 2018 +0100
>>
>>     Revert "x86/boot: Add the ACPI RSDP address to struct setup_header::acpi_rdsp_addr"
>>     
>>     This reverts commit 2f74cbf947f45fa082dda8eac1a1f1299a372f49.
>>
>> commit 0d0b6a9a0d452eaf635580fce8319d49be8b45ed
>> Author: Mike Galbraith <mgalbraith@suse.de>
>> Date:   Fri Jan 12 04:17:30 2018 +0100
>>
>>     Revert "x86/acpi: Take the RSDP address for boot parameters if available"
>>     
>>     This reverts commit 0c89cf36424f7c1177de8a5712514d7cc2eb369f.
>>
> 
> Ok, I've excluded tip:x86/boot from tip:master for the time being - these commits 
> are not v4.16 ready apparently.

Ingo, with my finding that above boot failure is related to a bug in
openSUSE's grub2 (I've verified it soesn't exist in upstream grub2),
I think my patches are fine for 4.16.

I've filed a bugzilla for SUSE's grub2.


Juergen