Message-ID: <1516028930.8238.87.camel@suse.de>
Subject: Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP
From: Mike Galbraith <mgalbraith@suse.de>
To: Juergen Gross <jgross@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>
Date: Mon, 15 Jan 2018 16:08:50 +0100
In-Reply-To: <2aeaae67-de23-423f-1233-fa0245bef575@suse.com>
References: <1515675936.7350.15.camel@suse.de>
         <20180111133723.d7x3sekanz5jhut2@gmail.com>
         <1515682631.16805.3.camel@suse.de>
         <20180111150331.7zzkd7awdxele54b@gmail.com>
         <20180111151044.GC6176@hirez.programming.kicks-ass.net>
         <1515694412.7054.10.camel@suse.de> <1515731128.10188.32.camel@suse.de>
         <668caea1-5a34-cf8e-a515-a7fa126bb7ee@suse.com>
         <1515744098.6703.11.camel@suse.de>
         <2aeaae67-de23-423f-1233-fa0245bef575@suse.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2018-01-15 at 15:41 +0100, Juergen Gross wrote:
> On 12/01/18 09:01, Mike Galbraith wrote:
> > On Fri, 2018-01-12 at 07:40 +0100, Juergen Gross wrote:
> >> On 12/01/18 05:25, Mike Galbraith wrote:
> >>> Hi Juergen,
> >>>
> >>> Yesterday I wanted to test the RETPOLINE stuff in tip and tip-rt, but
> >>> discovered instead that my box had turned into a complete slug, not due
> >>> to incredible RETPOLINE overhead, rather because box had forgotten that
> >>> it had more than one CPU. ?I was going to leave it for the weekend, but
> >>> firing up gitk over morning java, I noticed the commits below, and sure
> >>> enough, that's what broke my box. ?Given other people's boxen work,
> >>> seems likely that the authors of the AMI BIOS in this box were a bit
> >>> more creative than usual.
> >>
> >> So I'm curious how this should be possible.
> > 
> > Box is absolutely certain that it is.
> > 
> >> Some questions:
> >>
> >> - which bootloader are you using?
> > 
> > grub2, box is bog standard opensuse-42.3
> 
> And this is the problem.
> 
> grub2 of opensuse 42.3 is _wrong_.
> 
> It copies the setup_header in the size it knows of (last fiels is
> handover_offset), fills in some stuff, and then copies back 1024 bytes.
> So grub2 of openSUSE 42.3 is _not_ ready to accept extensions of
> bootparams.
> 
> This is a major breakage of the protocol, I think.

Oh joy, userspace b0rkage. ?Kernel b0rkage is a lot less annoying.?

Hohum, I have zero problem with carrying a revert until grub2 gets
fixed up, but lord knows how many others out there may bisect, and
bless your mailbox with the fruit of their labors :)

	-Mike