Subject: Re: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS
To: Guenter Roeck <linux@roeck-us.net>
References: <ca65ed8a-ac10-641a-a8fc-e042178b7451@linux.vnet.ibm.com>
Cc: arnd@arndb.de, jdelvare@suse.com, sam@mendozajonas.com,
        Andrew Jeffery <andrew@aj.id.au>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Eddie James <eajames@linux.vnet.ibm.com>
Date: Mon, 15 Jan 2018 09:24:25 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <ca65ed8a-ac10-641a-a8fc-e042178b7451@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Message-Id: <6b9d8164-a2cf-8449-ad97-6331494d8427@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org


On Fri, Jan 12, 2018 at 06:19:00PM +0100, Guenter Roeck wrote:
> On Fri, Jan 12, 2018 at 04:49:00PM +0100, Arnd Bergmann wrote:
> > Building without CONFIG_LEDS_CLASS causes a link failure:
> >
> > drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
> > ibm-cffps.c:(.text+0x4f4): undefined reference to 
> `devm_of_led_classdev_register'
> >
> > This adds the required dependency.
> >
> > Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor 
> (CFF) power supply driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I wanted to let Edward decide if he wants the new dependency or 
> conditional code
> in the driver. Not having heard from him, I'll take your patch instead 
> for now.

Thanks, yes this is a good solution for this driver. Didn't think about 
that during testing... Thanks Arnd.

Eddie

>
> Thanks,
> Guenter
>
> > ---
> >  drivers/hwmon/pmbus/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> > index 08479006c7f9..6e4298e99222 100644
> > --- a/drivers/hwmon/pmbus/Kconfig
> > +++ b/drivers/hwmon/pmbus/Kconfig
> > @@ -39,6 +39,7 @@ config SENSORS_ADM1275
> >
> >  config SENSORS_IBM_CFFPS
> >   tristate "IBM Common Form Factor Power Supply"
> > + depends on LEDS_CLASS
> >   help
> >    If you say yes here you get hardware monitoring support for the IBM
> >    Common Form Factor power supply.
> > --
> > 2.9.0
> >
>