Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755294AbeAOPit (ORCPT + 1 other); Mon, 15 Jan 2018 10:38:49 -0500 Received: from mout.web.de ([212.227.15.14]:53560 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbeAOPir (ORCPT ); Mon, 15 Jan 2018 10:38:47 -0500 Subject: Re: [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() To: Ladislav Michl , linux-omap@vger.kernel.org Cc: Lee Jones , Tony Lindgren , LKML , kernel-janitors@vger.kernel.org References: <7719b4e7-1081-6fa4-6f14-f45cf062482d@users.sourceforge.net> <20180115134101.GA6711@lenoch> From: SF Markus Elfring Message-ID: <1ebb5ac5-aa4d-7c19-94db-210b518d562f@users.sourceforge.net> Date: Mon, 15 Jan 2018 16:38:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180115134101.GA6711@lenoch> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:v4Re/CiDTxW19K4BkpFd039nccJNMGXEpqjeTgl256XeGqKBi5F H8qnqAcjlfkFA3QUmOLeOC1tHhwYkRKJBGEgaVfy6BNC03APvKRNPTpnMAFf1IQPZ4vkhF/ VuPSnVR1YQd7mS5PREYRgqliwlP+6UYQY4jXu3XRVYDIk/jGCaP7RMvexJgUkGuZczieBVS M1QPUI0fdXVdMh07Gj/HQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:FgY32dBJw9Y=:bi5sElVzZksGfHZTkfT6xH bkbSX2Dor9v4BxPwAiDlt50iG6EQTBpKTAbXcd17fXfgWif+JX00A5mXzI8cvbjrdy55KzLWt zLxkcb0jc+S3iab4eLo257AlZcuyc4Xp5Q36RNjnZOmzmOTR9x2Akqqae2gMK6OKB4KMAcG/V aIMSLwi+n7Ln+4KmwkTov9i8kH+iJ8z1CoCgp/WVXdli/ORLHW3g4rxgtJG2uf4cLroWzC6sM wcQqrpv0Sxx++XZc0u2Y/pNfuOeopl0inVkGt1INAXgOc2kGnnXUckJfmHkJN0oqns7idAfYE liR4KH/hfa3BE7hDmTQL7q0OXJ8xAGS+wydlRiuaBTmrRPIgudxpLvCH82t8h5DieT065gUc8 040U+vmVB2OjzexMsPXIYQHQr5g0pOb+3z6yZ240sODyqZc2rDIFBJho/aqX012+bWXQd2EIQ SNr2KFZDlNFk6me+8nAkGXl58QhXSuVAqXbO3AiKvrMNqX/JvqYd1q8B15weFjj1J6owiCdRi bVlZF9QJGEyNwMm5CSoukt4Xs1rr9kf79M1raQQx0LhIBy/egfqrIAfxERnLoiGv75lOmnZFH cbyd8Ko+CHHcIKrf7GGHefUSs/wZ9devlyUy95YvuIU3xgXMKsNMGKDejqkw8yx+T4yA7Uv7E TsfW/ZdMTDjPNWLd0zEhW2MnJeMlUnZU3SVSwB5pKUNZoaN3tTFnWEoDpf3a+6AvADZkb6VUQ qjseKyon2/yKBFByxmGjuZ/G6fw+iHcl2uNOsmGZ43Silniq0+PUEw+xmWe52+WK7SZGisq+7 wrf7Pv2aG3KrwBE96cO7VQQnyXlaSwZBBIM1BV7c34w2BaTeYg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: >> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device *pdev) >> GFP_KERNEL); >> if (!tll->ch_clk) { >> ret = -ENOMEM; >> - dev_err(dev, "Couldn't allocate memory for channel clocks\n"); > > I'd either leave this one, just to know which allocation failed or better use > something like this … Are you aware on the structure for a Linux allocation failure report? Regards, Markus