Subject: Re: [PATCH] blk_rq_map_user_iov: fix error override
To: Douglas Gilbert <dgilbert@interlog.com>,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: bart.vanassche@wdc.com, dvyukov@google.com
References: <20180114220048.8114-1-dgilbert@interlog.com>
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <0241d415-dc04-110a-771f-c245d963fec0@kernel.dk>
Date: Mon, 15 Jan 2018 08:50:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101
 Thunderbird/58.0
MIME-Version: 1.0
In-Reply-To: <20180114220048.8114-1-dgilbert@interlog.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 1/14/18 3:00 PM, Douglas Gilbert wrote:
> During stress tests by syzkaller on the sg driver the block layer
> infrequently returns EINVAL. Closer inspection shows the block
> layer was trying to return ENOMEM (which is much more
> understandable) but for some reason overroad that useful error.
> 
> Patch below does not show this (unchanged) line:
>    ret =__blk_rq_map_user_iov(rq, map_data, &i, gfp_mask, copy);
> That 'ret' was being overridden when that function failed.

Thanks, applied.

-- 
Jens Axboe