Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965825AbeAOPxb convert rfc822-to-8bit (ORCPT
        <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 15 Jan 2018 10:53:31 -0500
Received: from mga12.intel.com ([192.55.52.136]:46323 "EHLO mga12.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755527AbeAOPx2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Jan 2018 10:53:28 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,364,1511856000"; 
   d="scan'208";a="22363373"
From: "Liang, Kan" <kan.liang@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "eranian@google.com" <eranian@google.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>
Subject: RE: [PATCH V4 5/8] perf/x86/intel/uncore: add infrastructure for
 free running counter
Thread-Topic: [PATCH V4 5/8] perf/x86/intel/uncore: add infrastructure for
 free running counter
Thread-Index: AQHTVBltrNvBzLQkKEuSSgJ7i0nenKNzxNQAgAHDi1A=
Date: Mon, 15 Jan 2018 15:53:24 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0775380073F@SHSMSX103.ccr.corp.intel.com>
References: <1509654593-4446-1-git-send-email-kan.liang@intel.com>
 <1509654593-4446-5-git-send-email-kan.liang@intel.com>
 <alpine.DEB.2.20.1801142151440.2371@nanos>
In-Reply-To: <alpine.DEB.2.20.1801142151440.2371@nanos>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFjNDc1MDEtZTMyNS00MzkxLWE4YzEtOTFmYzNiZmVmOWQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJzaFNiUW5LWUZQbDNYZEU4MHpFR3NcL3N6V1lXaWxkeUo5bXZGbmMrVkQ0PSJ9
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

> On Thu, 2 Nov 2017, kan.liang@intel.com wrote:
> 
> > From: Kan Liang <Kan.liang@intel.com>
> >
> > The free running counter is read-only and always active. Current generic
> > uncore code does not support this kind of counters.
> >
> > The free running counter is read-only. It cannot be enable/disable in
> > event_start/stop.
> > The free running counter event and free running counter are 1:1 mapped.
> > It doesn't need to be assigned nor tracked by event_list.
> > The free running counters are always active. It doesn't need to check
> > the free running counters' availability.
> >
> > Use inline helpers to check fixed counter index and free running counter
> > index.
> >
> 
> That changelog is horrible to read. Other than that:
>

Hi Thomas,

Thanks for your review.

Sorry about the changelog.
I will modify the changelog and resend all the patches.

Thanks,
Kan
 
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>