Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935071AbeAOQ4Q (ORCPT + 1 other); Mon, 15 Jan 2018 11:56:16 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47936 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934380AbeAOQ4P (ORCPT ); Mon, 15 Jan 2018 11:56:15 -0500 Date: Mon, 15 Jan 2018 11:56:12 -0500 (EST) Message-Id: <20180115.115612.281197218565244967.davem@davemloft.net> To: steffen.klassert@secunet.com Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find."" From: David Miller In-Reply-To: <20180115132328.cuwcmhb262z2psgl@gauss3.secunet.de> References: <20180115123415.325497625@linuxfoundation.org> <20180115123418.624941321@linuxfoundation.org> <20180115132328.cuwcmhb262z2psgl@gauss3.secunet.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jan 2018 08:56:15 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Steffen Klassert Date: Mon, 15 Jan 2018 14:23:29 +0100 > On Mon, Jan 15, 2018 at 01:34:40PM +0100, Greg Kroah-Hartman wrote: >> 4.14-stable review patch. If anyone has any objections, please let me know. >> >> ------------------ >> >> From: "David S. Miller" >> >> >> This reverts commit 94802151894d482e82c324edf2c658f8e6b96508. >> >> It breaks transport mode when the policy template has >> wildcard addresses configured. >> >> Signed-off-by: David S. Miller >> Signed-off-by: Greg Kroah-Hartman > > Hm, this seems to be one revert too much. > > commit 94802151894d482e82c324edf2c658f8e6b96508 reverted already > the buggy commit. Reverting the revert will bring the bug back. Steffen, in the email where you asked me to revert that is the commit ID you referenced. We can drop this, but you need to then tell us whether 4.14 needs the revert any longer and if so what the correct SHA ID would be.