Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967419AbeAORWf (ORCPT + 1 other); Mon, 15 Jan 2018 12:22:35 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:41055 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966227AbeAORWd (ORCPT ); Mon, 15 Jan 2018 12:22:33 -0500 X-Google-Smtp-Source: ACJfBovKGq9e1tP03WR6+L5NU/gwGo92CHwaXbY3uae9H+GcNqE8mKYI6DwJ0Lan1kiEblXMQTs1vw== Subject: Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP To: Juergen Gross , Ingo Molnar Cc: Borislav Petkov , Mike Galbraith , LKML , Thomas Gleixner , Peter Zijlstra References: <20180111133723.d7x3sekanz5jhut2@gmail.com> <1515682631.16805.3.camel@suse.de> <20180111150331.7zzkd7awdxele54b@gmail.com> <20180111151044.GC6176@hirez.programming.kicks-ass.net> <1515694412.7054.10.camel@suse.de> <1515731128.10188.32.camel@suse.de> <20180112131144.bkopj2ooslwdyvoz@gmail.com> <0af5f083-b659-6c67-1ceb-a2bf9108c879@suse.com> <20180115145615.m54ewqg7vmvp4akj@pd.tnic> <20180115153243.3wst57a2fqin2h37@gmail.com> <3e29151d-0afc-c874-3e5e-557403ad10d3@gmail.com> <22bf2090-4319-080c-504d-8e38a9b67af1@suse.com> From: Gabriel C Message-ID: <68e10f13-cc5d-fbde-e971-5abee5ebf09e@gmail.com> Date: Mon, 15 Jan 2018 18:22:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <22bf2090-4319-080c-504d-8e38a9b67af1@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 15.01.2018 18:04, Juergen Gross wrote: > On 15/01/18 17:56, Gabriel C wrote: >> On 15.01.2018 17:42, Juergen Gross wrote: >>> On 15/01/18 17:29, Gabriel C wrote: >>>> On 15.01.2018 16:40, Juergen Gross wrote: >>>>> On 15/01/18 16:32, Ingo Molnar wrote: >>>>>> >>>> >>>> Hi Juergen, >>>> >>>>>> * Juergen Gross wrote: >>>>>> >>>>>>> On 15/01/18 15:56, Borislav Petkov wrote: >>>>>>>> On Mon, Jan 15, 2018 at 03:52:25PM +0100, Juergen Gross wrote: >>>>>>>>> Ingo, with my finding that above boot failure is related to a >>>>>>>>> bug in >>>>>>>>> openSUSE's grub2 (I've verified it soesn't exist in upstream >>>>>>>>> grub2), >>>>>>>> >>>>>>>> The box I'm seeing this on has SLES12-SP2 grub: >>>>>>>> >>>>>>>> Version        : 2.02~beta2-115.9.1 >>>>>>>> >>>>>>>> Does it have the same bug? >>>>>>> >>>>>>> The patch introducing this problem is from 2012. So I guess: yes. >>>>>> >>>>>> I suspect this makes it a widespread, unintended ABI. Can we detect >>>>>> and somehow avoid it? >>>>>> >>>>>> The boot protocol ABI sucks if it's fragile against such mistakes. >>>>> >>>>> Well, copying sizeof(setup_header) into grub2 and then coyping back >>>>> just >>>>> 1024 bytes is plain wrong. It is a miracle nothing broke up to now. >>>>> >>>> >>>> I'm not on SUSE and hit that too on an H11DSi-NT. >>>> See: https://marc.info/?l=linux-kernel&m=151579540320553&w=2 >>> >>> Where does your grub come from? >> >> https://github.com/frugalware/frugalware-current/tree/master/source/base/grub2 >> >> >> > > See line 409 of: > > https://github.com/frugalware/frugalware-current/blob/master/source/base/grub2/0019-Add-support-for-linuxefi.patch > > There you can see the memcpy with the wrong size back to the to be > booted kernel... > I see .. however Fedora have it too , Debian also.. https://src.fedoraproject.org/rpms/grub2/blob/master/f/0083-Add-support-for-linuxefi.patch#_409