Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935426AbeAORmC (ORCPT + 1 other); Mon, 15 Jan 2018 12:42:02 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42414 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755637AbeAORl4 (ORCPT ); Mon, 15 Jan 2018 12:41:56 -0500 Date: Mon, 15 Jan 2018 18:41:56 +0100 From: Greg KH To: Max Kellermann Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, linux-nfs@vger.kernel.org, trond.myklebust@primarydata.com, max.kellermann@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] dFrom: Max Kellermann Message-ID: <20180115174156.GB22809@kroah.com> References: <151603744662.29035.4910161264124875658.stgit@rabbit.intern.cm-ag> <151603745169.29035.6866708909114015882.stgit@rabbit.intern.cm-ag> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <151603745169.29035.6866708909114015882.stgit@rabbit.intern.cm-ag> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 06:30:51PM +0100, Max Kellermann wrote: > nfs/super: set MS_POSIXACL only if ACL support is enabled > > The code comment says "We will [apply the umask] ourselves", but that > happens in posix_acl_create() only if the kernel has POSIX ACL > support. Without it, posix_acl_create() is a is an empty dummy > function. Your subject line is a bit odd :(