Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935465AbeAORn4 (ORCPT + 1 other); Mon, 15 Jan 2018 12:43:56 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:40844 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756009AbeAORnx (ORCPT ); Mon, 15 Jan 2018 12:43:53 -0500 Date: Mon, 15 Jan 2018 18:43:47 +0100 (CET) From: Thomas Gleixner To: Ming Lei cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Laurence Oberman , Mike Snitzer Subject: Re: [PATCH 0/2] genirq/affinity: try to make sure online CPU is assgined to irq vector In-Reply-To: <20180115160345.2611-1-ming.lei@redhat.com> Message-ID: References: <20180115160345.2611-1-ming.lei@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, 16 Jan 2018, Ming Lei wrote: > These two patches fixes IO hang issue reported by Laurence. > > 84676c1f21 ("genirq/affinity: assign vectors to all possible CPUs") > may cause one irq vector assigned to all offline CPUs, then this vector > can't handle irq any more. > > The 1st patch moves irq vectors spread into one function, and prepares > for the fix done in 2nd patch. > > The 2nd patch fixes the issue by trying to make sure online CPUs assigned > to irq vector. Which means it's completely undoing the intent and mechanism of managed interrupts. Not going to happen. Which driver is that which abuses managed interrupts and does not keep its queues properly sorted on cpu hotplug? Thanks, tglx