Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbeAOSRa (ORCPT + 1 other); Mon, 15 Jan 2018 13:17:30 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:45136 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbeAOSR2 (ORCPT ); Mon, 15 Jan 2018 13:17:28 -0500 Date: Mon, 15 Jan 2018 18:17:24 +0000 From: Catalin Marinas To: Wei Yongjun Cc: James Morse , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt() Message-ID: <20180115181724.dwgzareorag7ndxc@armageddon.cambridge.arm.com> References: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 10:41:53AM +0000, Wei Yongjun wrote: > In case of error, the function of_platform_device_create() returns > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Fixes: 677a60bd2003 ("firmware: arm_sdei: Discover SDEI support via ACPI") > Signed-off-by: Wei Yongjun Applied. Thanks. -- Catalin