Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751278AbeAOShv (ORCPT + 1 other); Mon, 15 Jan 2018 13:37:51 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51740 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751173AbeAOShu (ORCPT ); Mon, 15 Jan 2018 13:37:50 -0500 Subject: Re: [PATCH v6 01/24] x86/mm: Define CONFIG_SPF To: Thomas Gleixner Cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org, akpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Ingo Molnar , hpa@zytor.com, Will Deacon , Sergey Senozhatsky , Andrea Arcangeli , Alexei Starovoitov , kemi.wang@intel.com, sergey.senozhatsky.work@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com, npiggin@gmail.com, bsingharora@gmail.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org References: <1515777968-867-1-git-send-email-ldufour@linux.vnet.ibm.com> <1515777968-867-2-git-send-email-ldufour@linux.vnet.ibm.com> <753d7b28-3d7e-0c01-0386-8dad161f88ea@linux.vnet.ibm.com> From: Laurent Dufour Date: Mon, 15 Jan 2018 19:37:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18011518-0012-0000-0000-000005A3F22A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011518-0013-0000-0000-0000191F61A2 Message-Id: <603205fb-21e5-859c-605c-fbd7b44438c0@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-15_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801150262 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 15/01/2018 18:49, Thomas Gleixner wrote: > On Mon, 15 Jan 2018, Laurent Dufour wrote: >> On 12/01/2018 19:57, Thomas Gleixner wrote: >>> On Fri, 12 Jan 2018, Laurent Dufour wrote: >>> >>>> Introduce CONFIG_SPF which turns on the Speculative Page Fault handler when >>>> building for 64bits with SMP. >>>> >>>> Signed-off-by: Laurent Dufour >>>> --- >>>> arch/x86/Kconfig | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >>>> index a317d5594b6a..d74353b85aaf 100644 >>>> --- a/arch/x86/Kconfig >>>> +++ b/arch/x86/Kconfig >>>> @@ -2882,6 +2882,10 @@ config X86_DMA_REMAP >>>> config HAVE_GENERIC_GUP >>>> def_bool y >>>> >>>> +config SPF >>>> + def_bool y >>>> + depends on X86_64 && SMP >>> >>> Can you please put that into a generic place as >>> >>> config SPF >>> bool >>> >>> and let the architectures select it. >> >> I'll change that to let the architectures (x86 and ppc64 currently) >> selecting it, but the definition will remain in the arch/xxx/Kconfig file >> since it depends on the architecture support in the page fault handler. > > Errm. No. > > config SPECULATIVE_PAGE_FAULT > bool > > goes into a generic config file, e.g. mm/Kconfig > > Each architecture which implements support does: > > select SPECULATIVE_PAGE_FAULT > > in arch/xxx/Kconfig Oh ok, I think I got it this time ;) Will do this way, this will be smarter. Thanks a lot, Laurent.