Date: Mon, 15 Jan 2018 20:18:43 +0100
Message-ID: <s5hk1wjc4mk.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Luis de Bethencourt" <luisbg@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        "Joe Perches" <joe@perches.com>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Takashi Sakamoto" <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH] ALSA: pcm: Fix trailing semicolon
In-Reply-To: <20180115181857.32105-1-luisbg@kernel.org>
References: <20180115181857.32105-1-luisbg@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 15 Jan 2018 19:18:57 +0100,
Luis de Bethencourt wrote:
> 
> From: Ubuntu <luisbg@kernel.org>

Is this from address intentional?  It'd be taken as is via git-am.


thanks,

Takashi

> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> ---
> 
> 
> Hi,
> 
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
> 
> Best regards 
> Luis
> 
> 
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> 
>  sound/core/pcm_native.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index 3f13e8da0812..51104df924e1 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
>  int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
>  			   struct vm_area_struct *area)
>  {
> -	struct snd_pcm_runtime *runtime = substream->runtime;;
> +	struct snd_pcm_runtime *runtime = substream->runtime;
>  
>  	area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
>  	return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
> -- 
> 2.15.1
> 
>