Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751243AbeAOTXI (ORCPT + 1 other); Mon, 15 Jan 2018 14:23:08 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:41366 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbeAOTXG (ORCPT ); Mon, 15 Jan 2018 14:23:06 -0500 Date: Mon, 15 Jan 2018 20:23:03 +0100 From: Ladislav Michl To: SF Markus Elfring Cc: linux-omap@vger.kernel.org, Lee Jones , Tony Lindgren , Roger Quadros , LKML , kernel-janitors@vger.kernel.org Subject: Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe() Message-ID: <20180115192303.GA31762@lenoch> References: <20180115134101.GA6711@lenoch> <1ebb5ac5-aa4d-7c19-94db-210b518d562f@users.sourceforge.net> <20180115160522.GA2672@lenoch> <11eaf92d-3928-531f-35e8-fb5a60ff03e3@users.sourceforge.net> <20180115163543.GA10657@lenoch> <20180115174122.GA20745@lenoch> <20180115183059.GA30039@lenoch> <8144f711-b4fd-730c-4e9f-780c42d5e68f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8144f711-b4fd-730c-4e9f-780c42d5e68f@users.sourceforge.net> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 08:04:03PM +0100, SF Markus Elfring wrote: > >> So I hope that your solution approach will be also fine. > >> Will it supersede my proposal? > > > > Who knows, perhaps it would be the best if you could judge yourself... > > I am also curious on how other contributors will respond to > your following update suggestion. > > > > 8<-------- > > > > Subject: [PATCH] mfd/omap-usb-tll: Allocate driver data at once > > Would it have been clearer to use this information as the subject > for this reply already? > > Are you fine with that this change approach was recorded in > a possibly questionable format? > https://patchwork.kernel.org/patch/10165193/ Sure. It does not seem anyone involved cares about patchwork. > > Allocating memory to store clk array together with driver > > data simplifies error unwinding and allows deleting memory > > allocation failure message as there is now only single point > > where allocation could fail. > > * Will it matter to mention the previous software situation a bit > in such a commit description? > > * Would you like to add a tag “link”? Are you okay with this one? https://lkml.org/lkml/2018/1/15/411 > * Are you going to “supersede” any more source code adjustments > around questionable error messages? I'm going to handle it usual way: - wait for feedback and modify accordingly - collect tags - resend as v2 Also, patch contains all your changes, so you should be credited somehow - hence the need for v2 anyway. What about: [marcus: simplified error unwinding, error message removal] Signed-off-by: Markus Elfring Feel free to propose anything else. Best regards, ladis