Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751309AbeAOTdt (ORCPT + 1 other); Mon, 15 Jan 2018 14:33:49 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:42766 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbeAOTdr (ORCPT ); Mon, 15 Jan 2018 14:33:47 -0500 Date: Mon, 15 Jan 2018 20:33:42 +0100 From: Ladislav Michl To: SF Markus Elfring Cc: linux-omap@vger.kernel.org, Lee Jones , Tony Lindgren , Roger Quadros , LKML , kernel-janitors@vger.kernel.org Subject: Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe() Message-ID: <20180115193342.GA32536@lenoch> References: <20180115134101.GA6711@lenoch> <1ebb5ac5-aa4d-7c19-94db-210b518d562f@users.sourceforge.net> <20180115160522.GA2672@lenoch> <11eaf92d-3928-531f-35e8-fb5a60ff03e3@users.sourceforge.net> <20180115163543.GA10657@lenoch> <20180115174122.GA20745@lenoch> <20180115183059.GA30039@lenoch> <9266b6cb-6b9f-5b76-dab8-8ec36269928f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9266b6cb-6b9f-5b76-dab8-8ec36269928f@users.sourceforge.net> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote: > > dev_dbg(dev, > > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > > - ver, tll->nch); > > + ver, nch); > > break; > > Does this format string need an other indentation when you touch this statement? Well, lets that the chance and make it shorter as well: default: - tll->nch = OMAP_TLL_CHANNEL_COUNT; - dev_dbg(dev, - "USB TLL Rev : 0x%x not recognized, assuming %d channels\n", - ver, tll->nch); + nch = OMAP_TLL_CHANNEL_COUNT; + dev_dbg(dev, "rev 0x%x not recognized, assuming %d channels\n", + ver, nch); break; Other proposals?