Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751076AbeAOTug (ORCPT + 1 other); Mon, 15 Jan 2018 14:50:36 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:58754 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750716AbeAOTud (ORCPT ); Mon, 15 Jan 2018 14:50:33 -0500 Date: Mon, 15 Jan 2018 19:49:58 +0000 From: Roman Gushchin To: Quentin Monnet CC: , , , Jakub Kicinski , Daniel Borkmann , Alexei Starovoitov Subject: Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs Message-ID: <20180115194952.GA14131@castle.DHCP.thefacebook.com> References: <20180115191615.13911-1-guro@fb.com> <34c43a17-7832-413e-fea8-4ad0f80f1585@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <34c43a17-7832-413e-fea8-4ad0f80f1585@netronome.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c092:200::1:8869] X-ClientProxiedBy: CWLP265CA0005.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:10::17) To CO1PR15MB1079.namprd15.prod.outlook.com (2a01:111:e400:7b66::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8bf92d2-c869-4814-16f3-08d55c512fa4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:CO1PR15MB1079; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;3:WZoMiqRO26xd3NkGxxHwpxT67eiSXWnF5+E4Mk+sxdjMfk5b4VUWpnv/uSD+cQ9wPeoGyoi6aCr7Bum/lCSKo/fxp8P5EAKvBHIgauEsyrjPr0ClsTNJKPpVow6D2xBnk7wnUpklR5NPRFmN0Osq671TxUDOMmn17gz4wLZdOKUZLqyppHhaNuBik+yoSdQN0Dzm0gFT8JMtuoD1+Ft4olxNUDN6MS2uz8x6+9NMeS0sQ4PTYkqvCpyB3V7Y3QKA;25:luV81HJ/9k3fJ5hTVgZ+xcH6dswbyfJM/HCZ39BhR0K7T1LF419GkVr1SCY81tnWH5aHdIx0rW4aBdlW/b5gwH87RRxMqKu/i8LdHG6/UZ+FU7uLCpwI7ZeX2TVefBoId3m+A2jttOkMNC+sB2Aim0EUtRyM+bKAqEMimFXRqVwgO70TZBYSrsMNugtUHq+ZDApGqKPvFT9JF4kODz3PJrDH0WRxXrm8xWNuNZ0gHu2B97AYVL6M3RnndHSTs6zp7Nvd71WABZBX5LQHb5EWIUTzsQXLFcjjptaZtxgo1XjXzAjvBm/V18XsCmcCN03zEUGmf3bYSUV4M1TyoqejGQ==;31:QSw67t39HmebEznDhKXJKyqdJwg1cgPTnmCfi81KoffMG+zk8JjgGuAR2ux9zVGpKvnXT5wl8nNDfAkUK5EW5F8YyWlsOgfBC++ONMB7CV5dJjcWiqj0tDBYaZCijlSQOmgxE19vyoXSHcl1mzWdEUPXrMMXw5csEonlDKn5jefX9hXxcFLUvU2QM84huH4rq+55yBM9Poq6a9YdSEyvxCcCt/upv0lpnHlswNtN++Q= X-MS-TrafficTypeDiagnostic: CO1PR15MB1079: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;20:klF1WIjpB7YUhHw9p9rHL6e7be1WSf4UD1diHLPnm1olXeBt1mhWYp5K+EGV5W+jr7rlmaY8/FEfmjaI5blX6+GPgRNoaFAPeWUmvnUOntU8YPE3cxNDY/wKp1fHgQUwV0lf+Yf0eXvUTQwEyiyre+yfBDaKuG84iWuTG7FZbcK4bml09pNogFwcZDQGJ+QhWyxNeh3QJXCeO6UtfHnarhoLuC0izcoX6N5xjO5puUZAeC/W0hWQYWlua/C2R4XjI7u4MQaMuq3qWqjipGX7G1++18hYBl0Spynl5/md+juQVigR7V8S9AN+6sdPuLja4A+HVpbk9QgbDWMAYQh8Gnh5qmuG1m7A+st+baQ2hMNGkJHsmuai5PCReuplCglnGXgzL8Q4taePhFpp94w/QB9kAPplBrbufXddbOdYN6ueNqePrA5FCtYWivapc8wh2aECH/ck8lA94OH5oNk8h3tcgfmp4mPSIGjIjSZHo0tSjpt5JmlRvW9UAfryvsXP;4:IODDuXKX/pQn1SJfvSJ1hkAkNyrmdVJdYPsgYXTEkfjFHudKJ6QeVRrQws4LCRy6cUgqbEG2496z+4ZZvd+ZKe8obDy3uf9cHNO6nHQIsHEyi/wcusGCkhipB1qoEpbspJjH/eXl18bXgNmf6DY6HuCp117BR3nI5iCzgB2GM/kp/Ev/fv5f+2hNaLgk7yCV2+hnMC6sFSJP4eTXnymz4uzN1WEurR5XgxA6SEe7QbWmAnGeJVNLzWWvs/G0QXZ8O8myDmlKXvFHOSol83DHa6ENN6GkjoPXO2mtg0p8qZ1IdiRDcPeoEfMnsE6asDM9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(11241501184)(944501161)(10201501046)(3002001)(6041268)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:CO1PR15MB1079;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CO1PR15MB1079; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(39380400002)(39860400002)(366004)(396003)(376002)(346002)(377424004)(24454002)(199004)(189003)(4326008)(50466002)(81156014)(8936002)(8676002)(81166006)(6246003)(229853002)(53936002)(33656002)(16586007)(6916009)(97736004)(55016002)(76176011)(316002)(39060400002)(6666003)(52396003)(6506007)(2950100002)(386003)(6116002)(68736007)(478600001)(9686003)(83506002)(54906003)(58126008)(25786009)(5660300001)(23726003)(105586002)(47776003)(106356001)(86362001)(2906002)(1076002)(305945005)(7696005)(7736002)(52116002)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB1079;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:3;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1079;23:azaesTs+yfqmuaIgoCLYGUdFFRTBzYjKkjEDcQgH4?= =?us-ascii?Q?ZhwUxq5ACATCzvS1rmNsCOSZaze7TeM9fBxR/R81xvjc1BRTQNj8Vd3wN66c?= =?us-ascii?Q?SbxHBxomVWfPHHY4ASCYPwrn2QeGIrkU6IcC+MvDyZUGJtHJvLTwlVRQ5Cks?= =?us-ascii?Q?QODohkW7dir1IUGWiu6eF+gj4hzYMqJLKHTIOyEiLfllUP+Uuafs2qK67wp7?= =?us-ascii?Q?9xDgz8UMkfS/z/08IOvgjft0EoaN7nj2tbljAWeV06XV36G02Ey49ulbBPu6?= =?us-ascii?Q?ZwcvS/k8mM3Ad5cIFqwRr9C5Sd5dBQ2F6XJdx0YcyhUdkFATvKnUi+7WrONO?= =?us-ascii?Q?XrqP85XAUNY0vLu2jlB6dSX15PSH5hz8o8ukHt8ynhar+JMmFMjFj2f6d2GA?= =?us-ascii?Q?li9diTaBDe0YgTIlCFVFnUoOd/oL7vIUYuEVNYsQxcwHirEnvlGQ2Rzg49LX?= =?us-ascii?Q?kiBJSdFakUeFcFydSwlYTKg51mD3om4x9PK+n+Vf+/1a2HM9tyowjquZgxqR?= =?us-ascii?Q?zcVl2kAbx4AUZBFcp3bmQnjGY69I+9j8a/VKHUIgxatQ60dDqpj5aS3nHuqm?= =?us-ascii?Q?PzVCHCwvTDEOcwevepBzQV7ayDpeu7pdhp9+ildnEiwg7lvDmqgwrf1A2ITg?= =?us-ascii?Q?BYM11sqxWnwd4Bm38d0wyAa8z4R8SvugfhZBF4F6+tqTyar7eZtHJlNg0y3Z?= =?us-ascii?Q?uvbE7gcduznyX4+bd2YGDSOuqsX/2pSsK8dB8LhJHH1A8ABVCkkKm/+ly54G?= =?us-ascii?Q?bgmKB5bzMk0hx4wctMxABOzgJhbkO3ToNopLHbi4dCw1Ucr851LC54h7eqXj?= =?us-ascii?Q?alLM0SJeE49622wdnb+1LtS3LGdfHxQoIPUmnBXECs/v0KWkZ58e5HpSyL49?= =?us-ascii?Q?3VaaPDsD9s8zUj6aqauVW+tFcFifVChKZmzcflDZshAj7wPm4hw87o/gnJCm?= =?us-ascii?Q?Ep6/tvoHIhG12JJQ5RR/8VA7kypsGaReyQB+w00YjBz6erq7kAka6mTviXJu?= =?us-ascii?Q?WHon7BmdPWG8DTd1VB3NFVWFecGk9mBPpKzGSvHe9lohaQQkPtAhZKofXJKJ?= =?us-ascii?Q?M/mADbsyNKMCiSXwiRaSmVnd93OtaQz/G3TpUJRQlqOVEYCO6EGckhNxKgEd?= =?us-ascii?Q?paU1myLCHGuof/Kpzvuv1gyBVGoHLTHjTU+b5rY2AwSVay3+I8teCaXyxCOY?= =?us-ascii?Q?xvwIXwt0L7iHs3CbHfMi65tOml1cERHwKqh4bPRHDcWyka8FfIif9bARaIYh?= =?us-ascii?Q?N7ypyTWAmhtSL2NiAc=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;6:XVoGG7aZ9B0fdxe6tFn8dfjDWcn32JgK5Zu5Z28UwDt5xZNBC54i6Ng72nwpvSMw7PtfVCkkCuYqp3soux5s3RVUfBzeJCWLaP3q310WyP45BiezEJagtAyCubJd4fXBoFXgq08e+EXwIt8fGqqzwOEUhfzxbGBpWEHnkPP2+/77bBBq4sEHjyS0efD0RJutBZgGP+yI7LGGCiEhRD4CoxqnbQ7XGjC7wFhbc6fk52Lm2+lmLXTC7gYb2SLQC0Va6b23XU9LnKdJKm6USAJvq+u35qPg/HD6Zyvm1JEle9SagpwlwE2OYgZXi8bliszDUvjFr0sjM/ZGF84dOyX6J1QnLwQHlQheTftNrH4DLlQ=;5:RfchAAE4m9NEa5spgyIo8v5tPL+czZBqIGutpFCI8YRpkYni5cqoDgEeZ0nDooN3AGoIdyod3fY7/2UjcVmIizRVTRD0Rg9zAJE260TSH7SmFiD6/FZXV4ZwVnbDpV6/XoZ7EMpjlBNbwNGmnyYRvOp+Wb8x4DsRVTnSmBYO/0I=;24:N+k6UYhoHHz679REJPDVJZeDrxRZ8Ot6Qg7A5r7++eyFtbQxX/Jt16surfxVbqv1/3cpX6Spil2tGTJAAwl6SB+YK22H6iQjx3LwSxI2qQM=;7:P73XbmDgi5tH4nh+4++ss9XErZ0o0KvUmhfB6jMzYhgMAWKUU/WabIZTLuGFvVSyblL4uo3gNDTEKSt/ZcgVsU+nCLikRO802WVBd1+wyIL7E7L+PB5H34ERmrELx9XBQPioIxTqtJ0OrEoQbTyDBIkWJEcq+egys32XPibm6x3+eSxhpioXjy9lNiqcM21opmoc7EWENKOD3Cqf7nbPlxO+gUhNc6c2MpPs6hCmPQMWr62SaPoKlm6hJmndMNXc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;20:oDWO6ro/VRWosUdcwVMle3JhjxRPrcHauK8frcYvabck5qZrpODuEqr80J12Y2Ef4qvBTeUlzm+/ruiJzC34vLe6TA56mCyuWmYHK0XdKzdgyC8dbYyR2AanzNI2e3UQL0YidbCV/PQxWsSf+jdmsbjhvyerR1vYT23NKdMJjq8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 19:50:08.9650 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b8bf92d2-c869-4814-16f3-08d55c512fa4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB1079 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-15_09:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote: > 2018-01-15 19:16 UTC+0000 ~ Roman Gushchin > > Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs, > > so the prog show command prints the numeric type value: > > > > $ bpftool prog show > > 1: type 15 name bpf_prog1 tag ac9f93dbfd6d9b74 > > loaded_at Jan 15/07:58 uid 0 > > xlated 96B jited 105B memlock 4096B > > > > This patch defines the corresponding textual representation: > > > > $ bpftool prog show > > 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74 > > loaded_at Jan 15/07:58 uid 0 > > xlated 96B jited 105B memlock 4096B > > > > Signed-off-by: Roman Gushchin > > Cc: Jakub Kicinski > > Cc: Quentin Monnet > > Cc: Daniel Borkmann > > Cc: Alexei Starovoitov > > --- > > tools/bpf/bpftool/prog.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c > > index c6a28be4665c..099e21cf1b5c 100644 > > --- a/tools/bpf/bpftool/prog.c > > +++ b/tools/bpf/bpftool/prog.c > > @@ -66,6 +66,7 @@ static const char * const prog_type_name[] = { > > [BPF_PROG_TYPE_LWT_XMIT] = "lwt_xmit", > > [BPF_PROG_TYPE_SOCK_OPS] = "sock_ops", > > [BPF_PROG_TYPE_SK_SKB] = "sk_skb", > > + [BPF_PROG_TYPE_CGROUP_DEVICE] = "cgroup_device", > > }; > > > > static void print_boot_time(__u64 nsecs, char *buf, unsigned int size) > > Looks good, thanks Roman! > Would you mind updating the map names as well? It seems the > BPF_MAP_TYPE_CPUMAP is missing from the list in map.c. Hello, Quentin! Sure, I'll take a look. Thanks!