Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751173AbeAOUHs (ORCPT + 1 other); Mon, 15 Jan 2018 15:07:48 -0500 Received: from mail-vk0-f67.google.com ([209.85.213.67]:40921 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbeAOUHr (ORCPT ); Mon, 15 Jan 2018 15:07:47 -0500 X-Google-Smtp-Source: ACJfBos9JbblSVS6XX+sIyYJZSUufZGyVA6OnW8mTfxs8gmvTW0FLJgVOONTR1/ajQJDEHhyJybCuVZEeTfK7CEHlqU= MIME-Version: 1.0 In-Reply-To: <20180115181839.keb4gyodwgruolk6@armageddon.cambridge.arm.com> References: <20171219192810.22537-1-labbott@redhat.com> <20180115181839.keb4gyodwgruolk6@armageddon.cambridge.arm.com> From: Kees Cook Date: Mon, 15 Jan 2018 12:00:50 -0800 X-Google-Sender-Auth: Po2G1AYEpq7F1i1H5UDga9JMYzA Message-ID: Subject: Re: [PATCH] arm64: Stop printing the virtual memory layout To: Catalin Marinas Cc: Laura Abbott , Mark Rutland , Will Deacon , LKML , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 10:18 AM, Catalin Marinas wrote: > On Tue, Jan 09, 2018 at 03:02:12PM -0800, Kees Cook wrote: >> On Tue, Dec 19, 2017 at 1:04 PM, Kees Cook wrote: >> > On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott wrote: >> >> Printing kernel addresses should be done in limited circumstances, mostly >> >> for debugging purposes. Printing out the virtual memory layout at every >> >> kernel bootup doesn't really fall into this category so delete the prints. >> >> There are other ways to get the same information. >> > >> > In looking at this patch, I wonder: is there anything listed here that >> > is _missing_ from CONFIG_PTDUMP? I would expect all of these to >> > already be listed there, but I thought I'd ask... >> > >> > Regardless: >> > >> > Acked-by: Kees Cook >> > >> > -Kees >> > >> >> >> >> Signed-off-by: Laura Abbott >> >> Did this patch get picked up? I don't see it in -next. > > I queued it now, should appear soon. Great, thanks! -Kees -- Kees Cook Pixel Security