Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbeAOU1O (ORCPT + 1 other); Mon, 15 Jan 2018 15:27:14 -0500 Received: from mga04.intel.com ([192.55.52.120]:59564 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbeAOUVt (ORCPT ); Mon, 15 Jan 2018 15:21:49 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,365,1511856000"; d="scan'208";a="22473473" From: kan.liang@intel.com To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Cc: wangnan0@huawei.com, jolsa@kernel.org, namhyung@kernel.org, ak@linux.intel.com, yao.jin@linux.intel.com, Kan Liang Subject: [PATCH V4 02/15] perf mmap: introduce perf_mmap__read_init() Date: Mon, 15 Jan 2018 12:20:38 -0800 Message-Id: <1516047651-164336-3-git-send-email-kan.liang@intel.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1516047651-164336-1-git-send-email-kan.liang@intel.com> References: <1516047651-164336-1-git-send-email-kan.liang@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Kan Liang The perf record has specific codes to calculate the ringbuffer position for both overwrite and non-overwrite mode. Now, only perf record supports both modes. The perf top will support both modes later. It is useful to make the specific codes generic. Introduce a new interface perf_mmap__read_init() to find ringbuffer position. The perf_mmap__read_init() is actually factored out from perf_mmap__push(). There are slight differences. - Add a check for map->refcnt - Add new return value logic, EAGAIN and EINVAL. Signed-off-by: Kan Liang --- tools/perf/util/mmap.c | 43 +++++++++++++++++++++++++++++++++++++++++++ tools/perf/util/mmap.h | 2 ++ 2 files changed, 45 insertions(+) diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c index 05076e6..414089f 100644 --- a/tools/perf/util/mmap.c +++ b/tools/perf/util/mmap.c @@ -267,6 +267,49 @@ static int overwrite_rb_find_range(void *buf, int mask, u64 head, u64 *start, u6 return -1; } +/* + * Report the start and end of the available data in ringbuffer + */ +int perf_mmap__read_init(struct perf_mmap *map, bool overwrite, + u64 *startp, u64 *endp) +{ + unsigned char *data = map->base + page_size; + u64 head = perf_mmap__read_head(map); + u64 old = map->prev; + unsigned long size; + + /* + * Check if event was unmapped due to a POLLHUP/POLLERR. + */ + if (!refcount_read(&map->refcnt)) + return -EINVAL; + + *startp = overwrite ? head : old; + *endp = overwrite ? old : head; + + if (*startp == *endp) + return -EAGAIN; + + size = *endp - *startp; + if (size > (unsigned long)(map->mask) + 1) { + if (!overwrite) { + WARN_ONCE(1, "failed to keep up with mmap data. (warn only once)\n"); + + map->prev = head; + perf_mmap__consume(map, overwrite); + return -EAGAIN; + } + + /* + * Backward ring buffer is full. We still have a chance to read + * most of data from it. + */ + if (overwrite_rb_find_range(data, map->mask, head, startp, endp)) + return -EINVAL; + } + return 0; +} + int perf_mmap__push(struct perf_mmap *md, bool overwrite, void *to, int push(void *to, void *buf, size_t size)) { diff --git a/tools/perf/util/mmap.h b/tools/perf/util/mmap.h index e43d7b5..0633308 100644 --- a/tools/perf/util/mmap.h +++ b/tools/perf/util/mmap.h @@ -94,4 +94,6 @@ int perf_mmap__push(struct perf_mmap *md, bool backward, size_t perf_mmap__mmap_len(struct perf_mmap *map); +int perf_mmap__read_init(struct perf_mmap *map, bool overwrite, + u64 *startp, u64 *endp); #endif /*__PERF_MMAP_H */ -- 2.5.5