Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbeAPAsZ (ORCPT + 1 other); Mon, 15 Jan 2018 19:48:25 -0500 Received: from mail.us.es ([193.147.175.20]:40372 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbeAPAsW (ORCPT ); Mon, 15 Jan 2018 19:48:22 -0500 Date: Tue, 16 Jan 2018 01:48:17 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Subash Abhinov Kasiviswanathan , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] netfilter: nf_defrag: move NF_CONNTRACK bits into #ifdef Message-ID: <20180116004817.4w43d7pflzbw6ubv@salvia> References: <20180115154918.4176669-1-arnd@arndb.de> <20180115154918.4176669-2-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180115154918.4176669-2-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 04:49:06PM +0100, Arnd Bergmann wrote: > We cannot access the skb->_nfct field when CONFIG_NF_CONNTRACK is > disabled: > > net/ipv4/netfilter/nf_defrag_ipv4.c: In function 'ipv4_conntrack_defrag': > net/ipv4/netfilter/nf_defrag_ipv4.c:83:9: error: 'struct sk_buff' has no member named '_nfct' > net/ipv6/netfilter/nf_defrag_ipv6_hooks.c: In function 'ipv6_defrag': > net/ipv6/netfilter/nf_defrag_ipv6_hooks.c:68:9: error: 'struct sk_buff' has no member named '_nfct' > > Both functions already have an #ifdef for this, so let's move the > check in there. Also applied, thanks.