Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbeAPAs6 (ORCPT + 1 other); Mon, 15 Jan 2018 19:48:58 -0500 Received: from mail.us.es ([193.147.175.20]:40526 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeAPAs4 (ORCPT ); Mon, 15 Jan 2018 19:48:56 -0500 Date: Tue, 16 Jan 2018 01:48:52 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , William Breathitt Gray , "Pablo M. Bermudo Garay" , Manuel Messner , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nf_tables: flow_offload depends on flow_table Message-ID: <20180116004852.ly4nzjgkhspdzftd@salvia> References: <20180112155033.3694504-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180112155033.3694504-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 12, 2018 at 04:50:26PM +0100, Arnd Bergmann wrote: > Without CONFIG_NF_FLOW_TABLE, the new nft_flow_offload module produces > a link error: > > net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_iterate_cleanup': > nft_flow_offload.c:(.text+0xb0): undefined reference to `nf_flow_table_iterate' > net/netfilter/nft_flow_offload.o: In function `flow_offload_iterate_cleanup': > nft_flow_offload.c:(.text+0x160): undefined reference to `flow_offload_dead' > net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_eval': > nft_flow_offload.c:(.text+0xc4c): undefined reference to `flow_offload_alloc' > nft_flow_offload.c:(.text+0xc64): undefined reference to `flow_offload_add' > nft_flow_offload.c:(.text+0xc94): undefined reference to `flow_offload_free' > > This adds a Kconfig dependency for it. Applied, thanks Arnd.