Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750846AbeAPDRB (ORCPT + 1 other); Mon, 15 Jan 2018 22:17:01 -0500 Received: from ozlabs.org ([103.22.144.67]:58861 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbeAPDRA (ORCPT ); Mon, 15 Jan 2018 22:17:00 -0500 From: Michael Ellerman To: Michal Suchanek , Benjamin Herrenschmidt , Paul Mackerras , Philippe Ombredanne , =?utf-8?Q?C=C3=A9dric?= Le Goater , David Gibson , Thomas Falcon , Michal Suchanek , "Tobin C. Harding" , Michael Neuling , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h In-Reply-To: <20180115133003.3447-1-msuchanek@suse.de> References: <20180115133003.3447-1-msuchanek@suse.de> Date: Tue, 16 Jan 2018 14:16:58 +1100 Message-ID: <87wp0ia3x1.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Michal Suchanek writes: > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > settings") uses u64 in asm/hvcall.h without including linux/types.h > > This breaks hvcall.h users that do not include the header themselves. > > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > settings") > > Signed-off-by: Michal Suchanek > --- > arch/powerpc/include/asm/hvcall.h | 1 + > 1 file changed, 1 insertion(+) Thanks. None of my ~250 defconfig test builds hit this, what config are you using? cheers > diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h > index f0461618bf7b..eca3f9c68907 100644 > --- a/arch/powerpc/include/asm/hvcall.h > +++ b/arch/powerpc/include/asm/hvcall.h > @@ -353,6 +353,7 @@ > #define PROC_TABLE_GTSE 0x01 > > #ifndef __ASSEMBLY__ > +#include > > /** > * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments > -- > 2.13.6